wallet: Remove mempool_sequence from interface methods #26752

1. 
   w0xlt commented at 9:28 am on December 26, 2022: contributor

   This PR removes mempool_sequence from transactionRemovedFromMempool and transactionAddedToMempool.

   mempool_sequence is not used in these methods, only in ZMQ notifications.

2. wallet: remove `mempool_sequence` from `transactionAddedToMempool` bf19069c53
3. wallet: remove `mempool_sequence` from `transactionRemovedFromMempool` 55696a0ac3
4. 
   DrahtBot commented at 9:28 am on December 26, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	instagibbs

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24230 (indexes: Stop using node internal types and locking cs_main, improve sync logic by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. DrahtBot added the label Wallet on Dec 26, 2022
6. glozow requested review from instagibbs on Dec 26, 2022
7. 
   instagibbs commented at 3:52 pm on January 4, 2023: member

   ACK https://github.com/bitcoin/bitcoin/pull/26752/commits/55696a0ac30bcfbd555f71cbc8eac23b725f7dcf

   Seems right to me.

8. 
   glozow commented at 5:53 pm on January 4, 2023: member

   Going off of #19572 description, it doesn’t seem like wallet would ever need this (cc @achow101 just in case). Seems like zmq sequence numbers are still correct after the change, so lgtm.
9. glozow merged this on Jan 4, 2023
10. glozow closed this on Jan 4, 2023

    ---

11. sidhujag referenced this in commit 7f01036510 on Jan 4, 2023
12. w0xlt deleted the branch on Jan 5, 2023
13. bitcoin locked this on Jan 5, 2024

Contributors
w0xlt DrahtBot instagibbs glozow

Review Requested
instagibbs

Labels
Wallet