Unit tests skip code paths for parallel_script_checks==false #26757

1. 
   hebasto commented at 3:13 pm on December 27, 2022: member

   The Chainstate::ConnectBlock() function is implemented in a way that different code paths are used during runtime depending on the parallel_script_checks flag’s value.

   OTOH, the current test suit implementation with the following lines:https://github.com/bitcoin/bitcoin/blob/e9262ea32a6e1d364fb7974844fadc36f931f8c6/src/test/util/setup_common.cpp#L189-L190 sets the parallel_script_checks to true for all cases.

   For example, the outcome of miner_tests is affected by the parallel_script_checks flag’s value.

2. hebasto added the label Tests on Dec 27, 2022
3. hebasto added the label Consensus on Dec 27, 2022
4. 
   kevkevinpal commented at 9:44 pm on December 31, 2022: contributor

   So do we want to modify the unit test to run miner_tests with both parallel_script_checks with both true and false?

   or are there any other alternatives

Contributors
hebasto kevkevinpal

Labels
Tests Consensus