ci: Move --enable-c++20 from “tidy” task back to “ASan…” one #26770

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:221229-c++20 changing 2 files +2 −2
  1. hebasto commented at 6:45 pm on December 29, 2022: member

    This PR reverts cc7335edc87c6ef34429b4df94f53973db520aac from #25528 partially.

    C++20 has introduced some new headers, and it is premature to consider them when using the IWYU tool.

    Required for #26763 and #26766.

    Related discussions:

  2. ci: Move `--enable-c++20` from "tidy" task back to "ASan..." one
    This change reverts cc7335edc87c6ef34429b4df94f53973db520aac partially.
    
    C++20 has introduced some new headers, and it is premature to consider
    them when using the IWYU tool.
    afc6052430
  3. hebasto added the label Tests on Dec 29, 2022
  4. DrahtBot commented at 6:45 pm on December 29, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. hebasto commented at 6:46 pm on December 29, 2022: member
    Friendly ping @0xB10C @MarcoFalke :)
  6. maflcko commented at 6:56 pm on December 29, 2022: member

    review only ACK afc60524305669b54ffa8857e3c053c6db6375f8

    Not sure why this was moved, but if CI passes now, this should be fine.

  7. maflcko commented at 7:22 pm on December 29, 2022: member
    Ah, this was a leftover from a previous iteration that used ./depends, see commit commit 8b1eac98282aae82762784323bf0fe0479e8a9fc: --enable-c++20 does not work with ./depends out of the box
  8. maflcko merged this on Dec 29, 2022
  9. maflcko closed this on Dec 29, 2022

  10. hebasto deleted the branch on Dec 29, 2022
  11. sidhujag referenced this in commit 9b25138576 on Dec 30, 2022
  12. bitcoin deleted a comment on Dec 31, 2022
  13. bitcoin locked this on Dec 31, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 19:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me