rpc: Remove duplicate field in RPCHelpMan for gettransactions #26777

pull jdjkelly wants to merge 1 commits into bitcoin:master from jdjkelly:rpc/get-transactions-typo changing 1 files +0 −1
  1. jdjkelly commented at 8:47 PM on December 30, 2022: contributor

    The field 'comment' appears twice in TransactionDescriptionString, incorrectly - this commit removes the instance of the comment field without a description, preserving the one with a description.

    On master, the duplicate fields can be be viewed here: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpc/transactions.cpp#L419-L423

    TransactionDescriptionString is included in RPC calls such as listtransactions which have functional tests.

  2. rpc: Remove duplicate field in RPCHelpMan for gettransactions
    The field 'comment' appears twice in TransactionDescriptionString,
    incorrectly - this commit removes the instance of the comment field
    without a description, preserving the one with a description
    090ad51c80
  3. DrahtBot commented at 8:47 PM on December 30, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK w0xlt

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label RPC/REST/ZMQ on Dec 30, 2022
  5. w0xlt approved
  6. hebasto commented at 11:17 AM on December 31, 2022: member

    It was introduced in #22798 (fa10fbc6658fb8d87118cd550e4de406dca45f23) by @MarcoFalke.

  7. maflcko commented at 12:39 PM on December 31, 2022: member

    Rendered diff:

    $ git diff -U4
    diff --git a/gettransaction b/gettransaction
    index 0157ebf..e2c3c9f 100644
    --- a/gettransaction
    +++ b/gettransaction
    @@ -28,9 +28,8 @@ Result:
         ...
       ],
       "replaced_by_txid" : "hex",              (string, optional) The txid if this tx was replaced.
       "replaces_txid" : "hex",                 (string, optional) The txid if the tx replaces one.
    -  "comment" : "str",                       (string, optional)
       "to" : "str",                            (string, optional) If a comment to is associated with the transaction.
       "time" : xxx,                            (numeric) The transaction time expressed in UNIX epoch time.
       "timereceived" : xxx,                    (numeric) The time received expressed in UNIX epoch time.
       "comment" : "str",                       (string, optional) If a comment is associated with the transaction, only present if not empty.
    diff --git a/listsinceblock b/listsinceblock
    index 3ed074e..9ad992d 100644
    --- a/listsinceblock
    +++ b/listsinceblock
    @@ -48,9 +48,8 @@ Result:
             ...
           ],
           "replaced_by_txid" : "hex",          (string, optional) The txid if this tx was replaced.
           "replaces_txid" : "hex",             (string, optional) The txid if the tx replaces one.
    -      "comment" : "str",                   (string, optional)
           "to" : "str",                        (string, optional) If a comment to is associated with the transaction.
           "time" : xxx,                        (numeric) The transaction time expressed in UNIX epoch time.
           "timereceived" : xxx,                (numeric) The time received expressed in UNIX epoch time.
           "comment" : "str",                   (string, optional) If a comment is associated with the transaction, only present if not empty.
    diff --git a/listtransactions b/listtransactions
    index 3b4a1dc..15a3a17 100644
    --- a/listtransactions
    +++ b/listtransactions
    @@ -44,9 +44,8 @@ Result:
           ...
         ],
         "replaced_by_txid" : "hex",          (string, optional) The txid if this tx was replaced.
         "replaces_txid" : "hex",             (string, optional) The txid if the tx replaces one.
    -    "comment" : "str",                   (string, optional)
         "to" : "str",                        (string, optional) If a comment to is associated with the transaction.
         "time" : xxx,                        (numeric) The transaction time expressed in UNIX epoch time.
         "timereceived" : xxx,                (numeric) The time received expressed in UNIX epoch time.
         "comment" : "str",                   (string, optional) If a comment is associated with the transaction, only present if not empty.
    
  8. maflcko merged this on Dec 31, 2022
  9. maflcko closed this on Dec 31, 2022

  10. jdjkelly deleted the branch on Dec 31, 2022
  11. sidhujag referenced this in commit f0c5d28975 on Jan 1, 2023
  12. bitcoin locked this on Dec 31, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me