Bitcoin Core startup is interrupted if there is the setting mintxfee=0 in bitcoin.conf #26797

issue GregTonoski openend this issue on January 2, 2023
  1. GregTonoski commented at 8:24 pm on January 2, 2023: none

    Expected behavior It is expected that Bitcoin Core is not shutdown automatically during startup. Moreover, it should be possible to set transaction fee at 0.

    Actual behavior Bitcoin Core Error mintxfee

    To reproduce

    1. Click bitcoin-qt.exe.

    System information

    1. A wallet that contained unspent funds was opened previously.
    2. The bitcoin.conf file contains “mintxfee=0”.
    3. Bitcoin Core 24.0.1 official binary for Windows (portable).
  2. GregTonoski added the label Bug on Jan 2, 2023
  3. maflcko commented at 8:38 am on January 3, 2023: member

    Looks like the 0 check was added in 000dc55181f77cd96076c76b2cc13f8bcbe4146e for no reason?

    (Maybe it was added as belt-and-suspenders for calls that set GMF_BLOCK, but none exist at that commit :man_shrugging: )

  4. willcl-ark referenced this in commit f11eb1fe27 on Jan 23, 2023
  5. willcl-ark commented at 3:12 pm on January 23, 2023: member

    @GregTonoski I made the change which would fix this issue for you linked in my commit above, but I am curious about the use-case you have for this? If you are not mining then you generally don’t want to have -mintxfee set much differently than what the wider network is using for -minrelaytxfee (and that miners are using for -blockmintxfee).

    If something like #26933 is merged, then this even extends to packages too.

    That being said, I somewhat agree that setting the feerate to 0 should not cause the program to exit.

  6. maflcko added the label Wallet on Jan 23, 2023
  7. maflcko commented at 3:19 pm on January 23, 2023: member
    Even if this is only useful for testing, handling 0 different from 0.00000001 (or so) seems odd
  8. willcl-ark commented at 4:20 pm on January 23, 2023: member
    Sure, that I agree with too! I’ll open that one-line fix then so we can close this out.
  9. fanquake closed this on Jan 24, 2023

  10. fanquake referenced this in commit f1b5d6be57 on Jan 24, 2023
  11. sidhujag referenced this in commit 23154f9996 on Jan 24, 2023
  12. aguycalled referenced this in commit 1184856133 on Jan 27, 2023
  13. GregTonoski commented at 5:08 pm on January 31, 2023: none

    I am curious about the use-case you have for this? If you are not mining then you generally don’t want to have -mintxfee set much differently than what the wider network is using for -minrelaytxfee (and that miners are using for -blockmintxfee).

    Creation of a 0-fee basic (movement of funds - nothing new or inventive) transaction is the use-case. (There were a few transactions recorded free-of-charge in Bitcoin last month).

  14. achow101 commented at 5:22 pm on January 31, 2023: member

    Creation of a 0-fee basic (movement of funds - nothing new or inventive) transaction is the use-case. (There were a few transactions recorded free-of-charge in Bitcoin last month).

    We generally don’t allow the creation of 0-fee transactions since they are unlikely to be relayed, nor accepted by our own mempool. The existence of 0-fee transactions in a block does not mean that they will propagate - these are often transactions made by the miners themselves (some pools do this for their payouts), or otherwise given to miners out of band.

  15. sipa commented at 5:55 pm on January 31, 2023: member
    There is an a privacy aspect to: we don’t relay transactions that aren’t acceptable to our own mempool, as doing so trivially identifies us as the source of the transaction.
  16. GregTonoski commented at 10:09 am on May 9, 2023: none
    I confirm that the bug is fixed 25.0rc1 (I have verified on the https://bitcoincore.org/bin/bitcoin-core-25.0/test.rc1/bitcoin-25.0rc1-win64.zip).
  17. bitcoin locked this on May 8, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me