test: merge banning test from p2p_disconnect_ban to rpc_setban #26863

1. 
   brunoerg commented at 1:25 PM on January 10, 2023: contributor

   There are tests related to banning in both p2p_disconnect_ban and rpc_setban, some of them are testing same scenarios. So, this PR moves all banning test stuff to rpc_setban and leaves p2p_disconnect_ban only for disconnecting stuff. Since p2p_disconnect_ban doesn't have any banning stuff, this PR also renames that to p2p_disconnect.

2. 
   DrahtBot commented at 1:25 PM on January 10, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29483 (test, ci: add --v1transport option, add --v2transport to a CI task by mzumsande)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Jan 10, 2023
4. 
   brunoerg commented at 1:29 PM on January 10, 2023: contributor

   cc: @andrewtoth (https://github.com/bitcoin/bitcoin/pull/26822#pullrequestreview-1238269263)

5. brunoerg force-pushed on Jan 10, 2023
6. brunoerg marked this as ready for review on Jan 10, 2023
7. brunoerg force-pushed on Jan 10, 2023
8. DrahtBot added the label Needs rebase on Jan 17, 2023
9. brunoerg force-pushed on Jan 17, 2023
10. DrahtBot removed the label Needs rebase on Jan 17, 2023
11. DrahtBot added the label Needs rebase on Feb 7, 2023
12. brunoerg force-pushed on Feb 7, 2023
13. DrahtBot removed the label Needs rebase on Feb 7, 2023
14. DrahtBot added the label Needs rebase on Feb 20, 2023
15. brunoerg force-pushed on Feb 20, 2023
16. DrahtBot removed the label Needs rebase on Feb 20, 2023
17. achow101 requested review from maflcko on Apr 25, 2023
18. DrahtBot added the label Needs rebase on Apr 27, 2023
19. brunoerg force-pushed on Apr 27, 2023
20. 
    brunoerg commented at 12:47 PM on April 27, 2023: contributor

    Rebased

21. DrahtBot removed the label Needs rebase on Apr 27, 2023
22. DrahtBot added the label Needs rebase on May 1, 2023
23. brunoerg force-pushed on May 1, 2023
24. 
    brunoerg commented at 10:28 PM on May 1, 2023: contributor

    Rebased

25. DrahtBot removed the label Needs rebase on May 1, 2023
26. DrahtBot added the label CI failed on May 1, 2023
27. 
    DrahtBot commented at 10:36 AM on May 2, 2023: contributor

    CI failed

28. brunoerg marked this as a draft on May 2, 2023
29. brunoerg force-pushed on May 2, 2023
30. brunoerg force-pushed on May 2, 2023
31. brunoerg marked this as ready for review on May 2, 2023
32. DrahtBot removed the label CI failed on May 2, 2023
33. DrahtBot added the label Needs rebase on Oct 3, 2023
34. brunoerg force-pushed on Oct 3, 2023
35. DrahtBot removed the label Needs rebase on Oct 3, 2023
36. DrahtBot added the label CI failed on Oct 4, 2023
37. DrahtBot removed the label CI failed on Oct 5, 2023
38. DrahtBot added the label CI failed on Oct 25, 2023
39. DrahtBot removed the label CI failed on Oct 29, 2023
40. DrahtBot added the label CI failed on Jan 13, 2024
41. DrahtBot added the label Needs rebase on Feb 8, 2024
42. test: merge `setban` test from `p2p_disconnect_ban` to `rpc_setban`

    Sometimes both ones are testing same stuff related to banning, it makes sense to merge them to avoid repetition.

    54d0e32193
43. test: remove ban test from `p2p_disconnect_ban` 370b843a75
44. rename `p2p_disconnect_ban` to `p2p_disconnect` 682ba546af
45. brunoerg force-pushed on Feb 13, 2024
46. 
    brunoerg commented at 9:46 PM on February 13, 2024: contributor

    Rebased

47. DrahtBot removed the label Needs rebase on Feb 13, 2024
48. DrahtBot removed the label CI failed on Feb 14, 2024
49. 
    glozow commented at 3:41 PM on February 16, 2024: member

    Since there doesn't seem to be very much review interest... is there any benefit in moving these tests to a different file?

50. 
    brunoerg commented at 3:48 PM on February 16, 2024: contributor

    Since there doesn't seem to be very much review interest... is there any benefit in moving these tests to a different file?

    Currently, there are stuff that are being test in both p2p_disconnect_ban and rpc_setban (e.g. "Test the ban list is preserved through restart" in setban and "setban: test persistence across node restart" in p2p_disconnect_ban). Since we have a specific test for setban RPC, the idea is concentrate everything about it there.

51. 
    DrahtBot commented at 2:43 PM on March 11, 2024: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

52. DrahtBot added the label Needs rebase on Mar 11, 2024
53. 
    brunoerg commented at 9:40 PM on March 20, 2024: contributor

    I'll close for now and work in a simpler alternative.

54. brunoerg closed this on Mar 20, 2024

    ---

55. bitcoin locked this on Mar 20, 2025

Review Requested
maflcko