Now that we use python 3.7, it makes the code less verbose and clearer to directly use capture_output when possible, see https://docs.python.org/3/library/subprocess.html#using-the-subprocess-module
scripted-diff: Use python 3.7 syntax capture_output=True #26914
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2301-py37-output-capture-🔔 changing 4 files +5 −5-
MarcoFalke commented at 4:09 PM on January 18, 2023: member
-
fa8818c582
scripted-diff: Use python 3.7 syntax capture_output=True
-BEGIN VERIFY SCRIPT- sed -i 's|stdout=\(subprocess.\)\?PIPE, stderr=\(subprocess.\)\?PIPE|capture_output=True|g' $(git grep -l PIPE) -END VERIFY SCRIPT-
-
DrahtBot commented at 4:10 PM on January 18, 2023: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Refactoring on Jan 18, 2023
- MarcoFalke added the label DrahtBot Guix build requested on Jan 18, 2023
- MarcoFalke removed the label DrahtBot Guix build requested on Jan 18, 2023
-
MarcoFalke commented at 4:16 PM on January 18, 2023: member
nvm, this doesn't work with
Popen, onlyrun - MarcoFalke closed this on Jan 18, 2023
- MarcoFalke deleted the branch on Jan 18, 2023
- hebasto deleted a comment on Jan 18, 2023
- fanquake locked this on Jan 18, 2023
Contributors
Labels