bitcoin-qt St13runtime_error during exit #2701

bitcoin-0.8.2-rc3 gitian x86_64

http://togami.com/~warren/temp/wallet.dat wallet.dat that reproduces this issue. This was created by kill -9 of previous bitcoin-qt after it hanged during shutdown in Issue #2690.

Bitcoin-Qt works properly, but during exit it crashes with this error:

receive version message: version 70001, blocks=238242, us=53.15.36.49:49450, them=188.79.149.44:8333, peer=188.79.149.44:8333 Added 1 addresses from 142.4.208.152: 63 tried, 14191 new addcon thread interrupt msghand thread interrupt dumpaddr thread stop net thread interrupt connection timeout opencon thread interrupt Flush(false) wallet.dat refcount=0 wallet.dat checkpoint wallet.dat detach wallet.dat closed DBFlush(false) ended 0ms StopNode() Flushed 14254 addresses to peers.dat 51ms

EXCEPTION: St13runtime_error
CDB() : can't open database file wallet.dat, error -30974
bitcoin in Runaway exception

It seems you're missing the necessary database/ subdir for this wallet. Recover using -salvagewallet.

I suppose Bitcoin should more gracefully handle this failure instead of being told this cyptic message.

Agree, except BDB is so arcane that I don't think we have a way to know what the actual problem is (except for trying to parse db.log itself).

A generic "Your wallet failed to open, want to try salvaging now?" would be nice, though. Then again, I really hope to get rid of BDB entirely soon anyway.