Nothing has changed that would affect Bitcoin’s usage of nanobench.
Here is a detailed list of the changes
Nothing has changed that would affect Bitcoin's usage of nanobench. Here is a detailed list of the changes
* Plenty of clang-tidy updates
* documentation updates
* faster Rng::shuffle
* Enable perf counters on older kernels
* Raise default minimum epoch time to 1ms (doesn't effect bitcoin's usage)
* Add support for custom information per benchmark
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
performance-* checks and related fixes by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
NOLINT markers in the upstream repository. This is a plain copy of the nanobench.h file from https://raw.githubusercontent.com/martinus/nanobench/v4.3.10/src/include/nanobench.h. This update compiles without warnings with the .clang-tidy changes in #26642.
2255@@ -2183,6 +2256,7 @@ struct IterationLogic::Impl {
2256 << ", mState=" << static_cast<int>(mState));
static_cast<double>(a.count()) with d(a) in the lines above?
d() helper and then forgot about it…
1977@@ -1905,7 +1978,7 @@ PerformanceCounters& performanceCounters() {
1978 // Windows version of doNotOptimizeAway
1979 // see https://github.com/google/benchmark/blob/master/include/benchmark/benchmark.h#L307
1980 // see https://github.com/facebook/folly/blob/master/folly/Benchmark.h#L280
1981-// see https://learn.microsoft.com/en-us/cpp/preprocessor/optimize
1982+// see https://docs.microsoft.com/en-us/cpp/preprocessor/optimize