ci: Cache stuff in volumes, not host folders #27033

1. 
   maflcko commented at 10:28 am on February 3, 2023: member

   Storing cached stuff in host system folders may lead to unexpected issues when the ci-built stuff is used for a non-ci build or a ci task leaks into another ci task.
2. 
   DrahtBot commented at 10:28 am on February 3, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	john-moffett

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Feb 3, 2023
4. maflcko force-pushed on Feb 3, 2023
5. maflcko renamed this:
   ci: Store depends in volume, not host folder
   ci: Cache stuff in volumes, not host folders
   on Feb 8, 2023
6. DrahtBot renamed this:
   ci: Cache stuff in volumes, not host folders
   ci: Cache stuff in volumes, not host folders
   on Feb 8, 2023
7. ci: Cache stuff in volumes, not host folders 5fffff54e9
8. maflcko force-pushed on Feb 8, 2023
9. 
   maflcko commented at 10:49 am on February 9, 2023: member

   Sanity check that ccache still works on the one task that runs this code path: https://cirrus-ci.com/task/5496539091566592?logs=ci#L2401
10. 
    john-moffett commented at 7:14 pm on February 9, 2023: contributor

    Approach ACK. Will test shortly.
11. john-moffett approved
12. 
    john-moffett commented at 3:34 pm on February 10, 2023: contributor

    tACK https://github.com/bitcoin/bitcoin/pull/27033/commits/5fffff54e9fcf154c722dc421025a567fa0c5c97

    Ran on Ubuntu arm64 host and performed as expected.

    I’m torn over whether this should be updated:

    https://github.com/MarcoFalke/bitcoin-core/blame/5fffff54e9fcf154c722dc421025a567fa0c5c97/ci/README.md#L10-L12

13. doc: Update ci docs fa8e92c022
14. 
    john-moffett commented at 4:08 pm on February 10, 2023: contributor

    ACK fa8e92c022057adcb8b98647bde626ed9c054df2
15. 
    maflcko commented at 4:09 pm on February 10, 2023: member

    Yes, thx, updated. I think there are some follow-ups possible:

    • Run the rsync -a /ro_base/ ... unconditionally, to a static folder name. Maybe /ci_scratch/?
    • Replace BASE_ROOT_DIR by either this folder or the host folder to avoid confusion.

    Also,

    • This should allow to remove the second user account in the docker container, as no files are propagated back
    • Maybe this cleanup can be done after #27028 to avoid conflicts

    Finally, running config.guess in https://github.com/bitcoin/bitcoin/blob/5fffff54e9fcf154c722dc421025a567fa0c5c97/ci/test/00_setup_env.sh#L33 may violate the statment that only the packages bash docker.io are required to run the CI system. Not sure how to fix this and if it is worth it.

16. maflcko merged this on Feb 13, 2023
17. maflcko closed this on Feb 13, 2023

    ---

18. maflcko deleted the branch on Feb 13, 2023
19. sidhujag referenced this in commit d4999cf6f1 on Feb 13, 2023
20. bitcoin locked this on Feb 13, 2024

Contributors
maflcko DrahtBot john-moffett

Labels
Tests