The descriptor inference logic would previously always use a dummy signing provider and would never analyze the witness script of a P2WSH scriptPubKey.
It’s often not possible to infer a Miniscript only from the onchain Script, but it was such a low hanging fruit that it’s probably worth having it?
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | instagibbs, achow101, sipa |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
ACK https://github.com/bitcoin/bitcoin/pull/27037/commits/03ccc34c9ec4fc6006b3163a36ea9f3fdc443690
might need release note?
here’s a couple more examples from taproot LN channels discussions that would be nice to include in test to check how it falls back to raw behavior:
Offered HTLC: 82012088a914ffffffffffffffffffffffffffffffffffffffff882102ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffad51b2 “desc”: “wsh(and_v(and_v(v:hash160(ffffffffffffffffffffffffffffffffffffffff),v:pk(02ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff)),older(1)))#twc36s59”
miniscript incompatible Offered HTLC: 82012088a914ffffffffffffffffffffffffffffffffffffffff882102ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffacb2 “desc”: “wsh(raw(82012088a914ffffffffffffffffffffffffffffffffffffffff882102ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffacb2))#ra6w2xa7”
ffff..ff.
The descriptor inference logic would previously always use a dummy
signing provider and would never analyze the witness script of a P2WSH
scriptPubKey.
Note even a valid Miniscript might not always be decodable from Script
without more contextual information (for instance the key preimage for a
pk_h).
