rpc: Use a FlatSigningProvider in decodescript to allow inferring descriptors for scripts larger than 520 bytes #27113

1. 
   achow101 commented at 4:44 pm on February 16, 2023: member

   FillableSigningProvider limits scripts to 520 bytes even though segwit allows scripts to be larger than that. We can avoid this limit by using a FlatSigningProvider so that such larger scripts can be decoded.

   Fixes #27111

2. rpc: Use FlatSigningProvider in decodescript

   Using a FillableSigningProvider results in decodescript being unable to
   infer descriptors for scripts larger than 520 bytes. Using a
   FlatSigningProvider resolves this.

   7cc7822371
3. tests: decodescript can infer descriptors for scripts >520 bytes 73ec4b2a83
4. 
   DrahtBot commented at 4:44 pm on February 16, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	instagibbs
   Concept ACK	sipa, darosior

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot added the label RPC/REST/ZMQ on Feb 16, 2023
6. 
   sipa commented at 4:44 pm on February 16, 2023: member

   Concept ACK
7. 
   instagibbs commented at 4:54 pm on February 16, 2023: member

   ACK https://github.com/bitcoin/bitcoin/pull/27113/commits/73ec4b2a8347c796b9aadc1f2576b286c469f9e7

   thanks for the quick turnaround

8. 
   darosior commented at 8:48 am on February 17, 2023: member

   Concept ACK, thanks for fixing my overlook.
9. 
   Sjors commented at 4:18 pm on February 20, 2023: member

   Tested that the new test fails without this change.
10. fanquake merged this on Feb 20, 2023
11. fanquake closed this on Feb 20, 2023

    ---

12. sidhujag referenced this in commit a645bd6899 on Feb 25, 2023
13. bitcoin locked this on Feb 20, 2024

Contributors
achow101 DrahtBot sipa instagibbs darosior Sjors

Labels
RPC/REST/ZMQ