test: p2p_message_capture.py fails with undefined sanitizer #27149

1. 
   Sjors commented at 8:02 pm on February 23, 2023: member

   On Ubuntu 22.10

   Relevant configure variable: --with-sanitizers=undefined

    0$ test/functional/p2p_message_capture.py 
    12023-02-23T19:55:57.251000Z TestFramework (INFO): PRNG seed is: 8604348948412116696
    22023-02-23T19:55:57.251000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_v2mn0yad
    32023-02-23T19:55:57.666000Z TestFramework (INFO): Stopping nodes
    4Traceback (most recent call last):
    5  File "test/functional/p2p_message_capture.py", line 72, in <module>
    6    MessageCaptureTest().main()
    7  File "/home/sjors/dev/bitcoin/test/functional/test_framework/test_framework.py", line 157, in main
    8    exit_code = self.shutdown()
    9  File "/home/sjors/dev/bitcoin/test/functional/test_framework/test_framework.py", line 313, in shutdown
   10    self.stop_nodes()
   11  File "/home/sjors/dev/bitcoin/test/functional/test_framework/test_framework.py", line 577, in stop_nodes
   12    node.stop_node(wait=wait, wait_until_stopped=False)
   13  File "/home/sjors/dev/bitcoin/test/functional/test_framework/test_node.py", line 356, in stop_node
   14    raise AssertionError("Unexpected stderr {} != {}".format(stderr, expected_stderr))
   15AssertionError: Unexpected stderr streams.h:556:19: runtime error: null pointer passed as argument 1, which is declared to never be null != 
   16[node 0] Cleaning up leftover process
   

   Seems pretty consistent on the latest master.

2. Sjors added the label Bug on Feb 23, 2023
3. 
   maflcko commented at 8:15 pm on February 23, 2023: member

   Did you set the suppression file? (env|grep UBSAN?)
4. 
   Sjors commented at 8:24 pm on February 23, 2023: member

   Which suppression file?

   Aha: https://github.com/bitcoin/bitcoin/blob/master/test/sanitizer_suppressions/ubsan

   We should point to it in https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#sanitizers

   It’s not clear to me how to use it.

5. 
   maflcko commented at 8:29 pm on February 23, 2023: member

   It’s not clear to me how to use it.

   #17834 (comment)

6. maflcko removed the label Bug on Feb 23, 2023
7. maflcko added the label Questions and Help on Feb 23, 2023
8. maflcko added the label Tests on Feb 23, 2023
9. 
   maflcko commented at 10:56 am on February 24, 2023: member

   Closing for now. Let us know if this is still an issue with the suppressions file.

   The doc questions should be handled in 17834

10. maflcko closed this on Feb 24, 2023

    ---

11. bitcoin locked this on Feb 24, 2024

Contributors
Sjors maflcko

Labels
Tests Questions and Help