Bitcoin-Qt: harmonize 2 setClientModel() functions #2731

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:rpcconsole changing 1 files +4 −2

Diapolo commented at 12:13 PM on June 3, 2013: none
- harmonize BitcoinGUI::setClientModel() and RPCConsole::setClientModel()
- now RPCConsole::setClientModel() also includes a direct call to setNumBlocks()

Bitcoin-Qt: harmonize 2 setClientModel() functions

- harmonize BitcoinGUI::setClientModel() and RPCConsole::setClientModel()
- now RPCConsole::setClientModel() also includes a direct call to
  setNumBlocks()

1fc57d568b

BitcoinPullTester commented at 2:07 PM on June 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1fc57d568b704f929890363a99d2a793956a15fe for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit fc1f360fce on Jun 5, 2013
laanwj merged this on Jun 5, 2013
laanwj closed this on Jun 5, 2013

in src/qt/rpcconsole.cpp:None in 1fc57d568b

 258 | +        // Keep up to date with client
 259 | +        setNumConnections(model->getNumConnections());
 260 |          connect(model, SIGNAL(numConnectionsChanged(int)), this, SLOT(setNumConnections(int)));
 261 | +
 262 | +        setNumBlocks(model->getNumBlocks(), model->getNumBlocksOfPeers());
 263 |          connect(model, SIGNAL(numBlocksChanged(int,int)), this, SLOT(setNumBlocks(int,int)));

luke-jr commented at 10:00 PM on July 15, 2013:

Shouldn't we get the initial value after connecting the signal handler, to avoid a race (we get, value changes, we hook signal)

Diapolo commented at 6:24 AM on July 16, 2013:

I'm not sure if I see the problem here, how the current ordering could cause an issue? Can you explain a little more please.

Bushstar referenced this in commit 2041186f4d on Apr 5, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

luke-jr