test: wallet_create_tx.py fix race #27318

1. 
   furszy commented at 7:48 pm on March 23, 2023: member

   Fixes #27316

   Because wallets are internally synchronized through the validation interface, and the interface dispatches events on a worker thread, it is possible for a transaction created by the first wallet to not arrive to the second wallet before the second wallet attempts to use one of its outputs. This is because we do not wait for the BroadcastTransaction callback during the wallet’s “submit to mempool” process. To address this in the tests, we need to manually sync the validation queue.

2. 
   DrahtBot commented at 7:48 pm on March 23, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	josibake, theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Mar 23, 2023
4. test: wallet_create_tx.py fix race

   Because wallets are internally synchronized
   through the validation interface, and the
   interface dispatches events on a worker thread,
   it is possible for a transaction created by the
   first wallet to not arrive at the second wallet
   before the second wallet attempts to use one of
   its outputs. This is because we do not wait for
   the BroadcastTransaction callback during the wallet's
   "submit to mempool" process. To address this in the
   tests, we need to sync the validation queue.

   8aab5157c5
5. furszy force-pushed on Mar 23, 2023
6. fanquake requested review from theStack on Mar 28, 2023
7. 
   josibake commented at 1:58 pm on March 28, 2023: member

   ACK https://github.com/bitcoin/bitcoin/pull/27318/commits/8aab5157c55249c9023ae4e9654f5d42aaa4f314
8. theStack approved
9. 
   theStack commented at 2:13 pm on March 28, 2023: contributor

   ACK 8aab5157c55249c9023ae4e9654f5d42aaa4f314
10. fanquake merged this on Mar 28, 2023
11. fanquake closed this on Mar 28, 2023

    ---

12. sidhujag referenced this in commit 13a44c77a4 on Mar 28, 2023
13. furszy deleted the branch on May 27, 2023
14. bitcoin locked this on May 26, 2024

Contributors
furszy DrahtBot josibake theStack

Labels
Tests