wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet #27337

1. 
   apoelstra commented at 0:25 am on March 27, 2023: contributor

   Importing pubkey-only descriptors works fine as long as the wallet already has the required privkeys.

   Happy to add whatever tests people advise me to.

   Fixes #27336

   Edit Never mind – we can update balances but not sign coins. More work needs to be done to support this.

2. wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet b86a605781
3. 
   DrahtBot commented at 0:25 am on March 27, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin-core/gui/650 (Add Import to Wallet GUI by KolbyML)
   • #26840 (refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc by KolbyML)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Wallet on Mar 27, 2023
5. apoelstra marked this as a draft on Mar 27, 2023
6. 
   apoelstra commented at 2:28 pm on March 27, 2023: contributor

   I’m going to close this; actually supporting what I want is a much more complicated job that I expected, and it would violate the scriptpubkeyman abstraction, so probably needs extensive discussion.
7. apoelstra closed this on Mar 27, 2023

   ---

8. bitcoin locked this on Mar 26, 2024

Contributors
apoelstra DrahtBot

Labels
Wallet