osx: fix bitcoin-qt startup crash when clicking dock icon #2741

pull theuni wants to merge 1 commits into bitcoin:master from theuni:fix-osx-dock changing 1 files +6 −2

theuni commented at 3:58 AM on June 5, 2013: member

Fixes a regression from Crash probably introduced by 4d17a1b0. Initialize the window to NULL and verify it before use.

Triggered in this case by running ./bitcoin-qt from a shell, and clicking on the icon before the window comes up.

osx: fix bitcoin-qt startup crash when clicking dock icon

Crash probably introduced by 4d17a1b0.
Inialize the window to NULL and verify it before use.

99add01e76

theuni commented at 3:59 AM on June 5, 2013: member

ping @jonasschnelli for review
jonasschnelli commented at 4:36 AM on June 5, 2013: contributor

ACK
BitcoinPullTester commented at 4:55 AM on June 5, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/99add01e76657ab7bc09d99c970b3ee08a0c9013 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 7:37 AM on June 5, 2013: member

Eek, mind your null pointers/uninitialized variables.

ACK
jonasschnelli commented at 7:38 AM on June 5, 2013: contributor

Yes. My fault. Sorry guys. thanks @theuni
laanwj referenced this in commit 83f9b58f15 on Jun 5, 2013
laanwj merged this on Jun 5, 2013
laanwj closed this on Jun 5, 2013
theuni deleted the branch on Jun 6, 2013
Bushstar referenced this in commit e63cdadc97 on Apr 5, 2019
DrahtBot locked this on Sep 8, 2021

Contributors