Add verbose flag to getblock RPC so it is possible to get hex dumps of blocks #2747

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:getblock_verbose0 changing 2 files +18 −3

luke-jr commented at 5:25 AM on June 7, 2013: member

It seems people keep wanting/needing this functionality.

Works like getrawtransaction, but defaults to 1 (unlike getrawtransaction) for backward compatibility.
SomeoneWeird commented at 6:08 AM on June 7, 2013: none

tested, ack.
jgarzik commented at 12:46 PM on June 7, 2013: contributor

Looks pretty good. Please use bool for boolean choices (example: gettxout). ACK if that is fixed.
sipa commented at 4:31 PM on June 7, 2013: member

Agree with @jgarzik. ACK otherwise.

EDIT: hmm, it seems getrawtransaction uses 0/1 for verbose... meh
luke-jr commented at 5:24 PM on June 7, 2013: member

Indeed... Boolean does make more sense, but usually consistency wins so far. Otherwise, we should be using Satoshi values everywhere... @jgarzik Any further thoughts? Agree/disagree?
jgarzik commented at 5:26 PM on June 7, 2013: contributor

Be consistent with gettxout, and use a boolean/get_bool()... :)
RPC: getblock(): Accept 2nd "verbose" parameter, similar to getrawtransaction, but defaulting to 1 for backward compatibility 2331952141
luke-jr commented at 5:45 PM on June 7, 2013: member

Done
jgarzik commented at 5:49 PM on June 7, 2013: contributor

ACK
jgarzik referenced this in commit 543d70a676 on Jun 10, 2013
jgarzik merged this on Jun 10, 2013
jgarzik closed this on Jun 10, 2013
luke-jr deleted the branch on Jan 1, 2015
Bushstar referenced this in commit e21d8d6b95 on Apr 5, 2019
DrahtBot locked this on Sep 8, 2021

Contributors