numToVarInt uses big endian instead of little endian #2774

issue shesek opened this issue on June 17, 2013
  1. shesek commented at 10:57 PM on June 17, 2013: contributor

    This only causes issues for values >= 0xfd that are represented using multiple bytes. I encountered it while serializing multisig transactions that has large scriptSig (it works fine with regular transactions, since they usually don't have >= 0xfd values).

    I attempted to reverse it myself, but it didn't work well - seems like some parts of the code expects it to return big endian?

  2. sipa commented at 9:03 AM on June 18, 2013: member

    There is no numToVarInt anywhere in our code, as far as I can see. Are you sure you didn't want to file this with (a guess:) bitcoin-js?

  3. jgarzik commented at 1:25 PM on June 18, 2013: contributor

    Not this project

  4. jgarzik closed this on Jun 18, 2013

  5. shesek commented at 3:11 PM on June 18, 2013: contributor

    Oops! Indeed, I meant to file that in bitcoinjs. My bad, sorry :)

  6. Bushstar referenced this in commit a69a5cf4a0 on Apr 5, 2019
  7. DrahtBot locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me