Users are now permitted to increase the keypool size at runtime.
Ideally they will update their config and restart, but that is not always feasible. This enables the admin to login, refill the keypool to handle heavy traffic needs immediately, without downtime.
However, the keypool target size returns to its configuration-specified value at restart, as expected.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7c1bb9a13226e7b46cc6836099809607ade8365a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Also, GetKeyPoolSize() now returns an accurate type, unsigned int.
48 | @@ -49,6 +49,7 @@ 49 | bool fTxIndex = false; 50 | unsigned int nCoinCacheSize = 5000; 51 | bool fHaveGUI = false; 52 | +unsigned int nKeyPoolTarget = 100;
This variable should be in CWallet, IMHO; certainly not a global in main.
Actually, why is this variable even necessary at all? Have CWallet::TopupKeyPool take an int size as argument, and pass GetArg("-keypool") to it, or where necessary an overridable value.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/36bd46f1c4330fa57a3730bd80706eca11510b55 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.