[src/{core_read,core_write,psbt,txorphanage}.cpp] Use correct `size_type` for `std::vector` iteration #27805

pull SamuelMarks wants to merge 1 commits into bitcoin:master from SamuelMarks:vector-size-type changing 4 files +10 −10
  1. SamuelMarks commented at 5:33 PM on June 2, 2023: none

    Note that size_t is not always size_type, but I haven't replaced your other usages of size_t throughout the codebase (I can upon request).

    Some details:

    Further discussion:

  2. [src/{core_read,core_write,psbt,txorphanage}.cpp] Use correct `size_type` for vector iteration accumulating variable ce331f8a91
  3. DrahtBot commented at 5:33 PM on June 2, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. maflcko commented at 5:44 PM on June 2, 2023: member

    We don't support WIN16 or DOS, etc, so your rationale from the stackoverflow link does not apply. The paper you linked to talks about something else. I haven't looked at the other links.

    Given that this doesn't change behavior or likely even the resulting binary, this qualifies as a style change:

    Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:

    • Time spent on review
    • Accidental introduction of bugs
    • (Silent) merge conflicts, either in the branch or a backport branch. Those conflicts demand further developer and reviewer time or introduce bugs.

    For more information about refactoring changes and stylistic cleanup, see

    Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.

    Let us know if you have any questions.

  5. maflcko closed this on Jun 2, 2023

  6. bitcoin locked this on Jun 1, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me