Please note, this is my first contribution to Bitcoin Core. I am not sure where the line of "significantly improving developer experience" is drawn, but this at least removes a warning from some static code checkers.
Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list #27812
pull Brotcrunsher wants to merge 1 commits into bitcoin:master from Brotcrunsher:master changing 2 files +2 −2-
Brotcrunsher commented at 4:22 PM on June 3, 2023: contributor
-
Style: Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list. 37ff03b493
-
DrahtBot commented at 4:22 PM on June 3, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
Brotcrunsher commented at 9:31 PM on June 3, 2023: contributor
Found more such occurrences. However, I will wait and see if such changes are welcome or denied.
-
hebasto commented at 9:41 PM on June 3, 2023: member
std::string argin these cases are very short strings. It's cheap to pass them by value. - hebasto renamed this:
Style: Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list
Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list
on Jun 3, 2023 -
glozow commented at 6:16 PM on June 4, 2023: member
Thank you for your contribution. We have a large amount of PRs requiring review attention, so closing this. Please see our contributing guidelines on refactoring and getting started.
- glozow closed this on Jun 4, 2023
- bitcoin locked this on Jun 3, 2024
Contributors