. #27839

pull aguycalled wants to merge 778 commits into bitcoin:master from navcoin:blsct-keypool-2 changing 1220 files +245849 −291488
  1. aguycalled commented at 5:50 PM on June 8, 2023: none

    This PR adds support for the use of a SubAddress pool and the generation of different receiving addresses.

    getnewaddress RPC method pulls addresses from the pool and shows to the requester receiving addresses.

    By default it generates addresses under account 0.

    It also introduces changes in blast::PublicKey to store the underlying point as a MclG1Point object, instead of a byte vector, since deserialisation of the vector is a expensive operation.

  2. add blsct tx fields to stringifiers and jsonifiers ca8c09e605
  3. optional blsct fields 5b24d90274
  4. update param name comment 9b7bd7f013
  5. add missing files in libbitcoinconsensus.vcxproj 8e70b1888e
  6. add common.props import to libbitcoinconsensus.vcxproj 5e3c28c5fd
  7. add missing secp256k1 include 28a9695db0
  8. trigger ci 82e73220bd
  9. changes at common.props 1e7e1608e3
  10. increase memory for fuzzer task c9625a865e
  11. increase cpu for fuzzer task 4a56903b1b
  12. increase cpus for vs task 40400e2444
  13. reduce cpus for vs task 42bec30e31
  14. reduce cpus for vs task d8a97210f0
  15. reduce cpus for vs task b495766946
  16. limit threads in common.init.vcxproj and increase again instance cpus 1eeff2a65f
  17. set number of threads as parameter for msbuild in cirrus.yml instead 691ec3dff8
  18. revert 233409bcad
  19. trigger ci 87a6ab9517
  20. optional extended range proof jsonifier cee1044b06
  21. Update mcl_scalar.cpp 4b90e91c25
  22. Update mcl_scalar.cpp 674bc160a0
  23. Merge pull request #107 from navcoin/tx-blsct-fields
    Add BLSCT Transaction fields
    d8abe5a8bc
  24. Merge remote-tracking branch 'btc/master' into btc-master
    	.cirrus.yml
	.github/ISSUE_TEMPLATE.md
	.github/ISSUE_TEMPLATE/bug_report.md
	.github/ISSUE_TEMPLATE/good_first_issue.md
	REVIEWERS
	ci/test/00_setup_env_i686_centos.sh
	ci/test/00_setup_env_native_fuzz_with_msan.sh
	ci/test/00_setup_env_native_msan.sh
	ci/test/00_setup_env_win64.sh
	ci/test/06_script_b.sh
	configure.ac
	doc/design/assumeutxo.md
	src/Makefile.am
	src/Makefile.qt_locale.include
	src/qt/*
	test/functional/test_framework/test_framework.py
    c4a1e34476
  25. Merge branch 'master' into btc-master
     Conflicts:
	src/bitcoind.cpp
	src/coins.cpp
	src/coins.h
	src/core_io.h
	src/crypto/muhash.cpp
	src/rpc/rawtransaction.cpp
	src/test/script_tests.cpp
	src/test/sighash_tests.cpp
	src/test/validation_flush_tests.cpp
    258b0094f8
  26. Merge remote-tracking branch 'btc/master' into btc-master
     Conflicts:
	src/qt/bitcoin.cpp
	src/qt/bitcoingui.cpp
	src/qt/bitcoingui.h
	src/qt/guiutil.cpp
	src/qt/initexecutor.cpp
	src/qt/transactionview.cpp
	src/qt/transactionview.h
	src/qt/walletview.cpp
	src/qt/walletview.h
    98e914b9c7
  27. Updated src/bitcoind.cpp to match upstream changes (Something happened in the previous merge where changes were skipped/missed somehow) 7bff1ae95f
  28. Updated src/rpc/rawtransaction.cpp (Had to revert some changes in 'getrawtransaction' func to match upstream 5f6498133f
  29. Fixed missing 'bool extendedRangeProof' para in TxToUniv function declaration a9a35db766
  30. Added LIBMCL and LIBBLS to navcoin_chainstate_LDADD 1c507a5c07
  31. Updated return 0; to be return nullptr since this func does not return an (int) 54fc4a6971
  32. Removed some GUI related code 9e7fcbc55c
  33. Updated the $GOAL to be "install\ instead of "deploy" since we don't have a GUI anymore 5bb50b3cdb
  34. Merge pull request #110 from mxaddict/btc-master
    Btc master 15/03/2023
    4623cbf7d9
  35. Added dandelion to BCLog:: in logging.h and logging.cpp 6bdf18fe92
  36. Added probing test for Dandelion++ 551fa58117
  37. Updated Dandelion++ probing test 6b5787f972
  38. Updated logging.cpp to handle BCLog::DANDELION in std::string LogCategoryToStr(BCLog::LogFlags category) db2a33ba0b
  39. OCD ac804aaaa2
  40. Added dandelion loop behavior test 5df2eb118c
  41. Better testing for Dandelion++ probing 7a505db862
  42. Added tx network loop test for Dandelion++ 587ed9cc40
  43. Added blackhole testing for Dandelion++ 1207712aca
  44. Updated the loop behavior and probing Dandelion++ tests to not have retries as they seem to be reliable without it 2fe0e497d3
  45. Updated the loop behavior and probing Dandelion++ tests to not have retries as they seem to be reliable without it 52f73f8063
  46. Updated comments in Dandelion++ test cases 3f74c805ed
  47. Added the 3 new tests to test_runner.py b15780bb10
  48. Removed COINBASE_MATURITY from Dandelion++ tests as they were unused 0c1a239fd7
  49. Updated Dandelion++ py tests to not rely on time travel for the probing and loop tests, and just add permissions for relay/mempool to the peer to bypass mempool security checks and directly access tx from mempool 09dd641fb7
  50. Updated some comments on the Dandelion++ tests 03b43b53f9
  51. Fixed a typo 62288b642c
  52. Added new MSG and INV types for DTX and DWTX for Dandelion++ 4130f072b7
  53. Added IsMsgDtx() and IsMsgDwtx() to CInv as well as modify IsGenTxMsg() to check for MSG_{DTX,DWTX} ba688a6c69
  54. Added MSG_DTX and MSG_DWTX to python test suite tools 6a934fca02
  55. Updated probing test to have 3 nodes instead of 1 36b58ffb28
  56. Updated Dandelion++ probing test to use circular network connection structure f27af96c89
  57. Updated tests to have comments higher up 7792a59325
  58. Updated tests to run MSG_DTX and MSG_DWTX in each case 5264d05021
  59. Added static const DANDELION_* globals a203c54aa2
  60. Added embargo time for stem phase mempool entries where needed d71e835061
  61. Fixed nTime/nEmbargo values c4db92a4bb
  62. OCD 92a4ac5b28
  63. Added embargo checking to 446f6f7928
  64. Better logic for embargo checking 2b61f763fb
  65. Added new message type DTX to fuzz test 5f7596fa65
  66. Reverted a change to src/test/validation_block_tests.cpp f7951c5e47
  67. Fixed time calculation for the embargo time 022946ac12
  68. Added comment to fix lint/tidy test 78a5146a3a
  69. Fix persistence for mempool 611f08c701
  70. Updated test/functional/p2p_dandelionpp_blackhole.py to only test DWTX 6e2be1655d
  71. Implemented more logic related to Dandelion++ like the MSG_DTX and MSG_DWTX support, mempool support, etc... 3387a193e9
  72. Added sync_all calls to dandelion tests e695db671d
  73. Fixed the logs 162dcf66b9
  74. Added more logging a5b381f2ec
  75. Updates to the test cases 7d4e71cd20
  76. Dandelion++ updates, should be working as expected now 2a41331dd6
  77. Reverted the change to CTransactionRef PeerManagerImpl::FindTxForGetData a478a90080
  78. Fixed some lint/tidy issues e07e1fa7d3
  79. Updated tests accoding to lint suggestions 3bd7dcb7e2
  80. Updated ShuffleStemRoutes to attempt reshuffle when no peers are selected to run faster on startup scenario b07315f2e9
  81. Changed the GUARD for m_next_stem_peer_shuffle 82c031c9b0
  82. Removed m_peer_mutex guards from void ShuffleStemRoutes(const std::vector<CNode*>& nodes) 7a6722bee9
  83. Added exclusive lock for !m_peer_mutex to ShuffleStemRoutes function a1f11d0187
  84. Added locks for tx_relay->m_tx_inventory_mutex in ShuffleStemRoutes d03bc9169c
  85. Removed [gui] from cirrus build for macOs e01501544c
  86. Updated test to check for dwtx instead of just wtx 2d362b283c
  87. Added MSG_DTX and MSG_DWTX to CInv processing for p2p.py c220d6c07e
  88. Change from OR syntax to in array syntax for checking MSG_* values 6670b63d2c
  89. Fix for a failure with old nodes that was waiting for MSG_TX instead of MSG_DTX 1e02d50451
  90. Fixed failure in p2p_tx_privacy.py 89aac7ba3d
  91. Updated how IsMsgTx() and IsMsgWtx work and removed IsMsgDtx and IsMsgWdtx 3683c249e2
  92. removed bool has_embargo from void RelayTransaction() as it's no longer used and added -dandelion flag for disabling dandelion to speed up some of the functional tests 48ce878333
  93. Revert "Fixed failure in p2p_tx_privacy.py"
    This reverts commit 89aac7ba3d300bb894124cd11ec9ac23e90a9cf7.
    d68e84d063
  94. Revert "Fix for a failure with old nodes that was waiting for MSG_TX instead of MSG_DTX"
    This reverts commit 1e02d504516461c9ba30acb39b008210f4ab7c22.
    66a00adcae
  95. Revert "Updated test to check for dwtx instead of just wtx"
    This reverts commit 2d362b283c1881ccafaf194aecd84b1a0f603c65.
    00bbc6643b
  96. Added `-dandelion` flag to tests that needed them and disabled for the rest ab753de739
  97. General refactoring and tying up lose ends 66c657d87d
  98. Removed a log call that is no longer needed 5394d71dae
  99. Implemented the fluff chance logic to pass value to ProcessTransaction for incoming DTX data d4b6ba64b4
  100. Reverted a code change that was no longer relevant 1d65702a82
  101. Fixed issue where accept_time was always uninitilized in fuzz/tx_pool.cpp f437298913
  102. removed unnecesary call to .GetHash() on a txid var 05e6b7697d
  103. Cleaned up some log calls to be condensed 608602deb3
  104. Disabled ShuffleStemRoutes when -dandelion=false 9d02c984aa
  105. Updated some of the dandelion tests and added a new fluff test f59e6403a0
  106. More changes to fluff test for dandelion 0af9051f58
  107. change fDandelionEnabled into a function 9b21d32aa4
  108. Merge branch 'dandelion-fresh' of github.com:mxaddict/navcoin into HEAD f3fab01673
  109. Updated embargo logic 20aef0f9df
  110. Added msg_dtx 977691b101
  111. Updated fluff testing logic 7af306f0b7
  112. Updated comment 79045e19aa
  113. Removed MSG_DWTX as we no longer use it 2e8bae0260
  114. Added test/functional/p2p_dandelionpp_fluffing.py to test runner cd60eb4a12
  115. Updating probing test cc441b0406
  116. Updated loop test 2fa7539caf
  117. Updated blackhole test to use only 2 nodes, we are just testing for the tx embargo expiry b2174fe8c3
  118. Updated loop test case for dandelion 3021334a50
  119. Merge branch 'dandelion-fresh' of github.com:mxaddict/navcoin into dandelion-fresh e16ac70a3e
  120. Updated node 1 and node 2 in loop test to be non dandelion to speed up the test aaa45d47f6
  121. Added missing calls to LOCK m_send_stem 12d67512cc
  122. Updated comment on loop test 43d808355f
  123. Added new test for mempool leak for Dandelion++ 6c4d58554f
  124. Removed some locks that were already locked f0cd1a4a76
  125. Moved the LOCK call to fix a crash 1df10552c4
  126. Removed CInv from py test as it was not used 65528f1a1d
  127. Made blackhole and mempool_leak tests more reliable b7f1d3689c
  128. Added msg_dtx to on_message parsing 7c772bc9c4
  129. More robust testing for blackhole and mempool leak 25b51e3a86
  130. Moved DANDELION related const values to new header file called `dandelion.h` 102ed18536
  131. Fixed include guards 6a359051f4
  132. Removed todo, we should not add an emabargo for orphaned tx that will be re added to mempool acda0cd3a3
  133. Merge pull request #81 from mxaddict/dandelion-fresh
    Dandelion++ Implementation
    795a59e033
  134. Merge remote-tracking branch 'btc/master' into btc-master
     Conflicts:
	ci/test/00_setup_env_native_tidy.sh
	ci/test/06_script_b.sh
	src/chainparams.cpp
	test/functional/rpc_psbt.py
    81d40f7916
  135. Updated skip_if_no_bitcoind_tracepoints call to be skip_if_no_navcoind_tracepoints 42eea14624
  136. Merge pull request #113 from mxaddict/btc-master
    Bitcoin upstream changes 24/03/2023
    f55303bf94
  137. Changes in serialization of transactions 14dbc73edb
  138. update test framework tx (de)serialization 6980f93a46
  139. trigger ci 66c974345a
  140. Merge pull request #114 from navcoin/improvements-serialization
    Changes in serialization of transactions
    6d1c3ed50e
  141. fix elements serialization cdfccb8df9
  142. Removed more GUI related depends configs 821d7b178a
  143. Merge pull request #115 from navcoin/fix-ser-elements
    Fix serialisation of Elements class
    104f453c65
  144. add working changes 7e5bebe8f6
  145. drop debug prints 9a0374712a
  146. add mistakenly dropped blockfiler.h in Makefile 37224ea77e
  147. fix typo 6bea4e743f
  148. fix typo 8ccb84130c
  149. fix typo 33754ab5b1
  150. replace sprintf w/ ostringstream. lower N in set mem proof setup d30f770815
  151. delete mistakenly copied file 1fea22bab4
  152. invoke ci 893919b85a
  153. improve verifying equations doc 5b2c52793e
  154. use bold font for vectors in verifying equations doc 76513a4198
  155. rename unity to zero 5374916241
  156. add bad input test case for set mem proof prover 6bdb3ad604
  157. invoke ci 1e583e8ec0
  158. create initial state of fiat-shamir with existing elements 608d7c29fb
  159. change comment 516a14ad28
  160. wip 9e12959d7e
  161. revert changes for testing d709665caf
  162. invoke ci 093dc2baac
  163. remove vector from de/serialization of elements 8c5dba36f1
  164. remove unused vector variable abf6280245
  165. remove maybe-uninitialized warning 98fba1d40f
  166. add elements de/serialization tests 1cd0890f48
  167. add scalar size check to test_serialize of elements_tests 1d33d4b699
  168. calculate inverses of xs in IIPA in one place 11d1e324db
  169. use more efficient algorithm in Element.Invert 1daf8c5717
  170. fix typo 021c603c71
  171. make generator deriver const and rename 105d459633
  172. generate c_factor with fiat-shamir and remove it from SetMemProof 08520beffb
  173. Merge pull request #118 from mxaddict/removed-qrencode-gui-from-depends
    Removed more GUI related depends configs
    c7b74828b5
  174. clean up Elements.Invert() d8767a6026
  175. add == and != operator overloads to SetMemProof and RangeProof and add th tests. Add deser test to RangeProof c34dc32478
  176. use fiat-shamir in place of str 9d2223b433
  177. rename transcript_gen to fiat_shamir. use fiat-shamir macros in range proof 8ba5e0c7a7
  178. add additional tests cases to set mem prover bf28d20126
  179. add set mem proof prover test case 9e5a4e0bf1
  180. fiat-shamir retry upon verification as well e35af47c43
  181. wip 6d1c7ca20b
  182. factor out pedersen commitment code to a class d77c84ec6e
  183. drop number of tries check in range proof prove 1fb3cacf71
  184. rename config to range proof setup 76aa226030
  185. integrate pedersen commitment generated for set membership proof to its setup class a1a4a15eb2
  186. invoke ci d9758da5fe
  187. fix elements invert for sanitizer error 1e4111cb53
  188. attempt to fix ci error 5f7b799076
  189. fix tests bef510d113
  190. fix tests 12f8b63eab
  191. make SetMemProofSetup::Get thread safe ce24fc4271
  192. make is_initialized class static variable b11b576ca0
  193. extend ys on verify side as well ec837f0af9
  194. make input power of 2 in the failing test f004117bd3
  195. Merge pull request #119 from gogoex/set-membership-proof
    Add set membership proof classes
    874dd0d373
  196. BLSCT Wallet KeyManager 672ca852c8
  197. Merge remote-tracking branch 'btc/master' into btc-master 48e9b89da5
  198. fixes 0b7c60ed47
  199. remove unused var 10d29a3b47
  200. remove unused fSkipCheck 9531d6094a
  201. add EXCLUSIVE_LOCKS_REQUIRED(cs_KeyStore); 35cde31625
  202. fix SetupBLSCTKeyMan caf0551ff9
  203. fixes src/wallet d864fcf8c6
  204. fix test/functional/tool_wallet.py 0293d4741e
  205. Merge pull request #116 from mxaddict/btc-master
    Upstream changes 05/11/2023
    03d181a3af
  206. Merge remote-tracking branch 'origin/master' into blsct-wallet-keygen 83158e0956
  207. Address ad4f9d7948
  208. walletload_test 53e4f49ad2
  209. fix headers 8066fe1798
  210. fixes abbb783e08
  211. add blsct::DoublePublicKey to ConsumeTxDestination 0271edd11b
  212. change constructors returned values 0c76785b44
  213. consume mclscalar 8ecb5f46fe
  214. m_blsct_key_manager d2bdc7bd4e
  215. do not move 5664d4cf5e
  216. do not return rand scalar when consuming in fuzzer 352d7026c5
  217. remove iszero check 984c8ac159
  218. remove iszero check test 34f9fa635e
  219. Fix doublepublickey encoding b8ab4a924f
  220. add log 1376adf52f
  221. remove log 876c3219fe
  222. unique_ptr for m_blsct_key_manager 5809e3e92a
  223. use std::move 975a711399
  224. Merge pull request #120 from navcoin/blsct-wallet-keygen
    BLSCT Wallet KeyManager
    6a8e55f3da
  225. BLSCT SubAddressPool 27d5e48f1e
  226. Remove unnecessary return 13b4977bae
  227. Retrigger CI d323020e76
  228. consider return value of SetVch() 689409bf23
  229. infinity test 8570cecfb4
  230. fixes 83a9c940d3
  231. fix initialization order 821542ec14
  232. Fid bench wallet_loading 0ca9e4b6d9
  233. remove disabled private keys check 3abe4e2fa6
  234. fixes c781d66e92
  235. locks 5f569fdf4e
  236. locks 6591b33699
  237. locks 2ab5982cd1
  238. fix py test 5ad627d5e1
  239. lock b132761a64
  240. locks 7e96746c1d
  241. trigger ci 4f0cb99639
  242. fix test wallet_backup d83f27f946
  243. fix wallet_avoidreuse 252553f90c
  244. fix tst wallet_backup 6164427d6d
  245. fix test wallet_address_types aa4cc690ac
  246. fix wallet_basic 9f79664efe
  247. fix tests c088ba60b3
  248. fix tool_wallet ed0bc41f4f
  249. retrigger ci 73d4508b9f
  250. retrigger CI 6a21eeb4ae
  251. retrigger CI 34ac304ffe
  252. DrahtBot commented at 5:50 PM on June 8, 2023: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  253. aguycalled closed this on Jun 8, 2023
  254. fanquake locked this on Jun 8, 2023
  255. fanquake renamed this:
    BLSCT SubAddress Pool
    .
    on Jun 8, 2023
Contributors
aguycalledDrahtBot
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me