move SelectParamsFromCommandLine() to bitcoin.cpp #2788

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:chainparams_init changing 2 files +5 −3

Diapolo commented at 4:08 PM on June 23, 2013: none
- move SelectParamsFromCommandLine() from init.cpp to bitcoin.cpp to allow to use TestNet() for Bitcoin-Qt instead of GetBoolArg("-testnet", false)
Does this still work for bitcoind, whose check resides in bitcoind.cpp AFAIK?

move SelectParamsFromCommandLine() to bitcoin.cpp

- move SelectParamsFromCommandLine() from init.cpp to bitcoin.cpp to allow
  to use TestNet() for Bitcoin-Qt instead of GetBoolArg("-testnet", false)

9cc55e24a0

Diapolo referenced this in commit 01b45731b7 on Jun 23, 2013
sipa commented at 4:25 PM on June 23, 2013: member

This won't work. Bitcoind wouldn't ever call SelectParamsFromCommandLine() anymore?
Diapolo commented at 4:29 PM on June 23, 2013: none

@sipa https://github.com/bitcoin/bitcoin/blob/master/src/bitcoind.cpp#L70 What about this?
sipa commented at 4:35 PM on June 23, 2013: member

@Diapolo Ah, that's for the RPC client, not for bitcoind's normal functions.
Diapolo commented at 4:45 PM on June 23, 2013: none

@sipa Could we then place that call (SelectParamsFromCommandLine()) here for bitcoind to work in all vairants? https://github.com/bitcoin/bitcoin/blob/master/src/bitcoind.cpp#L39
sipa commented at 5:11 PM on June 23, 2013: member

No, not before ReadConfigFile.
Diapolo commented at 8:18 AM on June 24, 2013: none

Doesn't yet do, what it should ;) -> closed.
Diapolo closed this on Jun 24, 2013
DrahtBot locked this on Sep 8, 2021

Contributors