exclude ipc scheme from port check #28020

pull JayBitron wants to merge 1 commits into bitcoin:master from JayBitron:master changing 1 files +1 −1

JayBitron commented at 12:25 PM on July 2, 2023: none

Previous PR #22087 cause new error, makes it impossible to use ipc protocol using zmq, this patch will exclude port checking on ipc urls.
exclude ipc scheme port check 0b1762c90d
DrahtBot commented at 12:25 PM on July 2, 2023: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #27375 (net: support unix domain sockets for -proxy and -onion by pinheadmz)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot renamed this:
~~exclude ipc scheme from port check~~
exclude ipc scheme from port check
on Jul 2, 2023

in src/init.cpp:1264 in 0b1762c90d

1260 | @@ -1261,7 +1261,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
1261 |          for (const std::string& socket_addr : args.GetArgs(port_option)) {
1262 |              std::string host_out;
1263 |              uint16_t port_out{0};
1264 | -            if (!SplitHostPort(socket_addr, port_out, host_out)) {
1265 | +            if (socket_addr.rfind("ipc:", 0) != 0 && !SplitHostPort(socket_addr, port_out, host_out)) {

luke-jr commented at 3:24 PM on July 4, 2023:

rfind is a very weird choice here. Suggest using compare

JayBitron commented at 9:16 PM on July 4, 2023:

compare throws an exception if the input string is lower than 4 character, but since this a conflict PR, please close it.

luke-jr changes_requested
luke-jr commented at 4:57 PM on July 4, 2023: member

nit: Rebasing onto bbbf89a9de0757c44880495244f90967f7147c0d would enable a clean merge to 25.x also
pinheadmz commented at 11:56 AM on July 6, 2023: member

See also #27679 which closes the same issue and has tests
JayBitron closed this on Jul 14, 2023
luke-jr referenced this in commit defe61d32a on Aug 16, 2023
bitcoin locked this on Jul 13, 2024

Contributors

Linked (view graph)

#22087 Validate port-options

exclude ipc scheme from port check #28020

Reviews

Conflicts