Gitignore auto-generated Secp256k1 files #28032

pull kibnakamoto wants to merge 1 commits into bitcoin:master from kibnakamoto:master changing 1 files +4 −0

kibnakamoto commented at 7:39 PM on July 5, 2023: none
After syncing the repo and compiling, three new automatically generated files were not ignored by git.
```
	src/secp256k1/src/libsecp256k1-config.h
	src/secp256k1/src/libsecp256k1-config.h.in
	src/secp256k1/src/stamp-h1
```
I added them to gitignore.
added secp256k1 auto-generated files 56af29cdb8
DrahtBot commented at 7:39 PM on July 5, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

kristapsk commented at 7:42 PM on July 5, 2023: contributor

I have even some more files after building.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	nodes_main.txt
	seeds_main.txt
	src/secp256k1/src/libsecp256k1-config.h
	src/secp256k1/src/libsecp256k1-config.h.in
	src/secp256k1/src/stamp-h1
	src/univalue/build-aux/
	src/univalue/test/no_nul

sipa commented at 7:44 PM on July 5, 2023: member

These files are not generated anymore; they're probably from an earlier compilation before the secp256k1 subtree was updated to a version that no longer uses the config file.
kibnakamoto commented at 8:05 PM on July 5, 2023: none

These files are not generated anymore; they're probably from an earlier compilation before the secp256k1 subtree was updated to a version that no longer uses the config file.

I used synced and pulled. Then compiled, these files were permenantly there.

As @kristapsk has mentioned, there are even more auto-generated files probably depending on the system one uses.
sipa commented at 8:09 PM on July 5, 2023: member

My guess is that these files are there from an earlier compilation, but weren't reported back then, because they used to be in (secp256k1's) .gitignore file. Now they are reported, but no longer created, because they're no longer in .gitignore. You can just delete them, and they won't be recreated.

See https://github.com/bitcoin-core/secp256k1/pull/1178.

As @kristapsk has mentioned, there are even more auto-generated files probably depending on the system one uses.

My comment is only about the 3 secp256k1 related ones.
hebasto commented at 8:38 PM on July 5, 2023: member
After syncing the repo and compiling, three new automatically generated files were not ignored by git.

src/secp256k1/src/libsecp256k1-config.h src/secp256k1/src/libsecp256k1-config.h.in src/secp256k1/src/stamp-h1
Since https://github.com/bitcoin/bitcoin/commit/e5c7fcb361d3379c254a52104b4ba25907cd07bb, these files are not generated by the build system.

I added them to gitignore.

There is no need for this.
fanquake closed this on Jul 6, 2023
bitcoin locked this on Jul 5, 2024

Contributors

Gitignore auto-generated Secp256k1 files #28032

Reviews