refactor: Make more transaction size variables signed #28059

1. 
   hebasto commented at 6:22 am on July 10, 2023: member

   This PR is a continuation of #23962 and it:

   • gets rid of two static casts,
   • addresses #23962 (comment),
   • is useful for #25972, see the failed ARM and multiprocess CI jobs.
2. 
   DrahtBot commented at 6:23 am on July 10, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke, glozow

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Refactoring on Jul 10, 2023
4. hebasto marked this as a draft on Jul 10, 2023
5. hebasto marked this as ready for review on Jul 10, 2023
6. 
   maflcko commented at 6:35 am on July 10, 2023: member

   Not sure. The other types are 64 bit, so this will overflow eventually
7. hebasto force-pushed on Jul 10, 2023
8. 
   maflcko commented at 7:53 am on July 18, 2023: member

   Are you still working on this?
9. 
   hebasto commented at 1:31 pm on July 20, 2023: member

   Not sure. The other types are 64 bit, so this will overflow eventually

   Are you still working on this?

   Since the recent push, the totalSizeWithAncestors is int64_t.

10. refactor: Make more transaction size variables signed

    This change gets rid of `static_cast`s and compiler warnings.

    92de74ef18
11. in src/txmempool.cpp:158 in a359d7a920 outdated

    154@@ -155,12 +155,12 @@ void CTxMemPool::UpdateTransactionsFromBlock(const std::vector<uint256>& vHashes
    155 }
    156 
    157 util::Result<CTxMemPool::setEntries> CTxMemPool::CalculateAncestorsAndCheckLimits(
    158-    size_t entry_size,
    159+    int32_t entry_size,
    

    ---

    ---

    

    maflcko commented at 4:11 pm on July 20, 2023:

    No it is not. this is still int32_t

    ---

    

    hebasto commented at 7:00 am on July 22, 2023:

    Thanks! Updated.
12. hebasto renamed this:
    refactor: Make more transaction size variables `int32_t`
    refactor: Make more transaction size variables signed
    on Jul 22, 2023
13. hebasto force-pushed on Jul 22, 2023
14. 
    maflcko commented at 1:47 pm on July 26, 2023: member

    lgtm ACK 92de74ef181b42d774bc6b12329bc0c27caf0081 🥔

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: lgtm ACK 92de74ef181b42d774bc6b12329bc0c27caf0081  🥔
    30ZbMecPPNsqm48/rdeMDLieCAN7U9sumAkW0RxVcIcITZiQOe2nPM1mEeI1s9L8p25tLucM8vrLa+nu2sfmGBg==
    

15. fanquake requested review from glozow on Aug 2, 2023
16. 
    glozow commented at 10:41 am on August 3, 2023: member

    ACK 92de74ef181b42d774bc6b12329bc0c27caf0081
17. glozow merged this on Aug 3, 2023
18. glozow closed this on Aug 3, 2023

    ---

19. hebasto deleted the branch on Aug 3, 2023
20. sidhujag referenced this in commit 61e007ef93 on Aug 9, 2023
21. bitcoin locked this on Aug 2, 2024

Contributors
hebasto DrahtBot maflcko glozow

Labels
Refactoring