Bugfix: Only try to use git describe when .git directory exists #2808

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bugfix_git_describe changing 4 files +4 −4

luke-jr commented at 4:16 PM on July 1, 2013: member

Otherwise, git will happily seek to find a git directory at higher levels.
Bugfix: Only try to use git describe when .git directory exists 83e0a83aeb
BitcoinPullTester commented at 10:35 PM on July 1, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/83e0a83aebee095588f2acf357e890b12380da07 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 10:31 PM on July 2, 2013: member

Funny, 3 pull requests which fix the same issue open at the same time (#2804 does this also).
laanwj commented at 8:10 AM on August 10, 2013: member

None of the three ever got merged, though :package: Shall we merge this one or close it in favor of autotools when it becomes mergeable? (as I remember autotools was about ready to merge, only needs a final squash, OKs and maybe support from pulltester)
Diapolo commented at 12:10 PM on August 10, 2013: none

@laanwj Do we still maintain bitcoin-qt.pro after that autotools stuff got merged? I'm a bit sceptical about it, because I never worked with it and I feel comfortable with our .pro file ^^.
laanwj commented at 8:43 AM on August 23, 2013: member

Yes, we'll keep the bitcoin-qt.pro, at least as long as needed (the automake plugin for qt creator isn't up to level yet with .pro, for example it doesn't show a nice tree anymore). We'll have to maintain it ourselves, though, we cannot rely on anyone else keeping it up to date as others will build with automake.
jgarzik commented at 2:56 AM on August 25, 2013: contributor

ACK
Diapolo commented at 12:49 PM on October 10, 2013: none

Obsolete because of Autotools?
laanwj commented at 1:47 PM on October 10, 2013: member

AFAIK autotools has fixed this, so it can be closed
laanwj closed this on Oct 10, 2013
Bushstar referenced this in commit 4b4234f390 on Apr 5, 2019
DrahtBot locked this on Sep 8, 2021

Contributors