descriptor: do not parse from script unspendable Miniscript descriptors #28112

pull darosior wants to merge 1 commits into bitcoin:master from darosior:miniscript_from_script_unspendable changing 2 files +4 −1

darosior commented at 1:23 PM on July 20, 2023: member

#27997 but for Script parsing.

I've added a test demonstrating the behaviour despite the descriptor parsing also currently being incorrect (wsh(raw()), see #28067). I guess whichever comes after the other between this PR and #28067 would be trivial to rebase on to fix it.
descriptor: do not parse from script unspendable Miniscript descriptors
https://github.com/bitcoin/bitcoin/pull/27997 but for Script parsing.
3dc840635f
DrahtBot commented at 1:23 PM on July 20, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
darosior commented at 1:25 PM on July 20, 2023: member

Actually i'm not even sure we'd like to do this, as i don't see how it could be a footgun for a user.
darosior commented at 1:31 PM on July 20, 2023: member

Closing this, sorry for the noise. I don't think it is useful to forbid parsing a Miniscript descriptor from Script since it cannot be a footgun for end user and it's always better to parse a Miniscript, even though unspendable, than a raw Script to be displayed in some utilities (such as decodescript for instance).
darosior closed this on Jul 20, 2023
bitcoin locked this on Jul 19, 2024

Contributors