p2p_getaddr_caching.py failure in TSan CI #28133

issue jonatack opened this issue on July 23, 2023

jonatack commented at 7:35 PM on July 23, 2023: member

https://cirrus-ci.com/task/5471865133596672?logs=ci#L3981

 test  2023-07-22T19:16:17.696000Z TestFramework (ERROR): Assertion failed 
                                   Traceback (most recent call last):
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
                                       self.run_test()
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_getaddr_caching.py", line 74, in run_test
                                       addr_receiver_onion1 = self.nodes[0].add_p2p_connection(AddrReceiver(), dstport=self.onion_port1)
                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 652, in add_p2p_connection
                                       assert_equal(len(info), 1)
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 57, in assert_equal
                                       raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
                                   AssertionError: not(2 == 1)
 test  2023-07-22T19:16:17.697000Z TestFramework (DEBUG): Closing down network thread 
 test  2023-07-22T19:16:17.747000Z TestFramework (INFO): Stopping nodes 
 test  2023-07-22T19:16:17.748000Z TestFramework.node0 (DEBUG): Stopping node

Is there an existing issue for this?

I have searched the existing issues

maflcko commented at 2:06 PM on July 24, 2023: member

https://cirrus-ci.com/task/6450543510421504?logs=ci#L3872 in Asan
maflcko commented at 2:07 PM on July 24, 2023: member

cc @vasild 20b49460b35268db59f7efcb02736b0e31191a74
mzumsande commented at 1:02 AM on July 25, 2023: contributor

See #28144 for a fix.
vasild commented at 8:56 AM on July 25, 2023: contributor

It is good to put asserts that can never the triggered because sometimes they are.
fanquake closed this on Aug 1, 2023
sidhujag referenced this in commit c744ab6024 on Aug 9, 2023
BlackcoinDev referenced this in commit 1b5cbf71df on Feb 5, 2024
bitcoin locked this on Jul 31, 2024

Contributors

Linked (view graph)

#28144 test: fix intermittent failure in p2p_getaddr_caching.py