ci: Keep system env vars as-is (bugfix) #28138

1. 
   maflcko commented at 1:16 pm on July 24, 2023: member

   This fixes a bug where the $PATH from the host is used inside the container. This will lead to bugs when the $PATH is different. For example on a host of Fedora 38, and a container of debian:bullseye.

   This can be tested with the FILE_ENV=./ci/test/00_setup_env_arm.sh CI env. On master:

   0Error: crun: executable file `bash` not found in $PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found
   

   On this pull:

   (everything passes)

2. 
   DrahtBot commented at 1:16 pm on July 24, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27976 (ci: Start with clean env by MarcoFalke)
   • #27793 (ci: label docker images and prune dangling images selectively by stickies-v)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot renamed this:
   ci: Keep system env vars as-is (bugfix)
   ci: Keep system env vars as-is (bugfix)
   on Jul 24, 2023
4. DrahtBot added the label Tests on Jul 24, 2023
5. maflcko force-pushed on Jul 24, 2023
6. DrahtBot added the label CI failed on Jul 24, 2023
7. DrahtBot added the label Needs rebase on Jul 24, 2023
8. ci: Remove P_CI_DIR and --workdir

   The --workdir setting to the docker run command is not needed. And
   P_CI_DIR/PWD is equal to BASE_ROOT_DIR, so just use that directly.

   fac229ab1f
9. ci: Set PATH inside the CI env

   This is needed for the next commit.
   
   This also requires dropping CI_RETRY from the docker build step, which
   is fine, because CI_RETRY should be called inside the build script, not
   outside.
   
   Also, fix a doc typo.

   fa8dcdcc8b
10. ci: Keep system env vars as-is fabc04a4d9
11. maflcko force-pushed on Jul 24, 2023
12. DrahtBot removed the label Needs rebase on Jul 24, 2023
13. DrahtBot removed the label CI failed on Jul 24, 2023
14. TheCharlatan approved
15. 
    TheCharlatan commented at 11:17 am on July 28, 2023: contributor

    lgtm ACK fabc04a4d96c4fe70e60d365aa28031d149094f3
16. fanquake merged this on Jul 28, 2023
17. fanquake closed this on Jul 28, 2023

    ---

18. maflcko deleted the branch on Jul 28, 2023
19. sidhujag referenced this in commit 4e0ddb8790 on Aug 9, 2023
20. bitcoin locked this on Jul 27, 2024

Contributors
maflcko DrahtBot TheCharlatan

Labels
Tests