bad opcode err msg includes reserved, because reserved opcode is evaluated as BAD_OPCODE(and it's wrong to state missing or not undestood for it).
fix: bad opcode err msg includes reserved opcode #28234
pull ChrisCho-H wants to merge 1 commits into bitcoin:master from ChrisCho-H:script/bad-opcode-reserved changing 2 files +2 −2-
ChrisCho-H commented at 3:22 PM on August 7, 2023: none
-
DrahtBot commented at 3:22 PM on August 7, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
jonatack commented at 3:37 PM on August 7, 2023: member
If this change is correct, the failing tests would need to be updated in the same commit (see https://jonatack.github.io/articles/how-to-contribute-pull-requests-to-bitcoin-core for more details).
-
fix: bad opcode err msg includes reserved opcode 39888f29e9
- ChrisCho-H force-pushed on Aug 7, 2023
- DrahtBot added the label CI failed on Aug 7, 2023
- DrahtBot removed the label CI failed on Aug 8, 2023
-
ChrisCho-H commented at 12:21 PM on August 8, 2023: none
Thx, I updated in same commit.
-
ChrisCho-H commented at 1:38 PM on August 10, 2023: none
closed as it would be better to integrate this update here https://github.com/bitcoin/bitcoin/pull/28169
- ChrisCho-H closed this on Aug 10, 2023
- bitcoin locked this on Aug 9, 2024
Contributors