Bitcoin-Qt: save and restore position of debug window #2827

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:rpccon_winpos changing 5 files +34 −30

Diapolo commented at 11:17 AM on July 13, 2013: none
- move the code for saving and restoring window positions from BitcoinGUI to GUIUtil, make it more generic and also use it for saving/restoring debug window positions
We also could allow this for all other dialogs, if we want, but that is currently not the goal of this pull.
laanwj commented at 5:41 AM on July 19, 2013: member

I'd prefer factoring out this code to utility functions or an utility class, instead of just copying it.
Diapolo commented at 5:44 AM on July 19, 2013: none

@laanwj That IS a good idea, thanks.
Diapolo commented at 11:21 AM on July 19, 2013: none

@laanwj Can you take another look :)?
BitcoinPullTester commented at 4:50 AM on July 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fc63a85f6deb17504c206796c9d7a87922588986 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 2:04 PM on July 20, 2013: member

ACK on code changes, haven't yet tested

Bitcoin-Qt: save and restore position of debug window

- move the code for saving and restoring window positions from BitcoinGUI
  to GUIUtil, make it more generic and also use it for saving/restoring
  debug window positions

c431e9f1f0

Diapolo commented at 2:24 PM on July 29, 2013: none

Updated commit-msg and also removed <QSettings> and <QDesktopWidget> include from bitcoingui.cpp.
BitcoinPullTester commented at 12:36 PM on August 1, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c431e9f1f03023d216db0ff48d3d598e705c97f9 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 7:20 AM on August 5, 2013: none

@laanwj Did you test the patch yet?
gavinandresen commented at 7:57 AM on August 5, 2013: contributor

ACK: tested on OSX.
gavinandresen referenced this in commit a4ae02969e on Aug 5, 2013
gavinandresen merged this on Aug 5, 2013
gavinandresen closed this on Aug 5, 2013
DrahtBot locked this on Sep 8, 2021

Contributors