rpc: remove one more quote from non-string oneline description #28289

pull mzumsande wants to merge 1 commits into bitcoin:master from mzumsande:202208_fix_oneline_description changing 1 files +1 −1
  1. mzumsande commented at 8:25 pm on August 17, 2023: contributor

    This fixes a silent conflict between #28123 (which removed all \"options\") and #27460 (which added a new one).

    It should fix the current CI failures.

  2. rpc: remove one more quote from non-string oneline description
    This fixes a silent conflict betwen #28123 and #27460
    2394314442
  3. DrahtBot commented at 8:25 pm on August 17, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK jonatack, ajtowns, MarcoFalke, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label RPC/REST/ZMQ on Aug 17, 2023
  5. jonatack commented at 8:41 pm on August 17, 2023: contributor

    ACK 239431444216850b63ecf01c3b5c5d6d24230d08

    With this change, ./test/functional/test_runner.py --jobs=11 --timeout-factor=0 --coverage no longer warns as it does on current master

    0Uncovered RPC commands:
    1  - Internal
    

    and .oneline_description in this RPC is set to a value similar to that in the other RPCs.

  6. ajtowns commented at 4:44 am on August 18, 2023: contributor
    utACK 239431444216850b63ecf01c3b5c5d6d24230d08
  7. MarcoFalke commented at 5:56 am on August 18, 2023: member
    lgtm ACK 239431444216850b63ecf01c3b5c5d6d24230d08
  8. MarcoFalke added this to the milestone 26.0 on Aug 18, 2023
  9. MarcoFalke added the label Bug on Aug 18, 2023
  10. hebasto approved
  11. hebasto commented at 7:31 am on August 18, 2023: member
    ACK 239431444216850b63ecf01c3b5c5d6d24230d08
  12. fanquake merged this on Aug 18, 2023
  13. fanquake closed this on Aug 18, 2023


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-29 07:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me