rpc: removed StrFormatInternalBug quote delimitation #28291

1. 
   russeree commented at 2:57 am on August 18, 2023: contributor

   This PR rectifies an unnecessary set of quotes delimiting the contents of StrFormatInternalBug. This is a follow up to MarcoFalke #28123 (review). The method of action was to remove the escaped quotes that were a part of strprintf. A single functional test case was modified to reflect the new output format.

   STR_INTERNAL_BUG was applied to #28123 in std::string RPCArg::ToString(const bool oneline) in rpc/util.cpp

   The results can be seen below.

   Previously

   This PR

   Additional context can be found here. #28123 (review)

   Thank you.

2. 
   DrahtBot commented at 2:58 am on August 18, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke, stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. russeree renamed this:
   removed StrFormatInternalBug quote delimitation
   rpc: removed StrFormatInternalBug quote delimitation
   on Aug 18, 2023
4. DrahtBot added the label RPC/REST/ZMQ on Aug 18, 2023
5. russeree marked this as a draft on Aug 18, 2023
6. removed StrFormatInternalBug quote delimitation 6e8f6468cb
7. russeree force-pushed on Aug 18, 2023
8. DrahtBot added the label CI failed on Aug 18, 2023
9. russeree marked this as ready for review on Aug 18, 2023
10. 
    maflcko commented at 6:07 am on August 18, 2023: member

    review ACK 6e8f6468cbf1320b70cf01333002a31b44cb7c33

    Makes sense to use a single function consistently. This will now also print file, line, func of where the check is located, not where the presumed bug is located, but this seems fine, because the bug could also be in the check. In theory, there could be a flag to disable file, line, func, but that seems over-optimizing for developer-only code paths that are rarely hit.

11. maflcko removed the label CI failed on Aug 18, 2023
12. fanquake requested review from stickies-v on Aug 18, 2023
13. stickies-v approved
14. 
    stickies-v commented at 7:01 pm on September 4, 2023: contributor

    ACK 6e8f6468cbf1320b70cf01333002a31b44cb7c33
15. 
    maflcko commented at 7:22 am on September 5, 2023: member

    rfm, or is anything left to be done here?
16. fanquake merged this on Sep 5, 2023
17. fanquake closed this on Sep 5, 2023

    ---

18. Frank-GER referenced this in commit 12ebf85b66 on Sep 8, 2023
19. bitcoin locked this on Sep 4, 2024

Contributors
russeree DrahtBot maflcko stickies-v

Labels
RPC/REST/ZMQ