If it's easy, why not?
I know test_framework isn't meant for anything but regtest testing, but I could see someone naively copying the ECKey class and using it elsewhere.
Will benchmark to make sure this isn't noticeably slower.
test: use cryptographic random number gen #28326
pull jamesob wants to merge 1 commits into bitcoin:master from jamesob:jamesob-23-08-no-milksad changing 1 files +10 −4-
jamesob commented at 3:46 PM on August 22, 2023: member
-
DrahtBot commented at 3:46 PM on August 22, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Tests on Aug 22, 2023
-
86ca75ff5d
test: use cryptographic random number gen
If it's easy, why not?
- jamesob force-pushed on Aug 22, 2023
-
sipa commented at 3:51 PM on August 22, 2023: member
Why not? I'd say because it doesn't add anything (for tests, weaker randomness is fine) and may confuse potential people looking at the code (you still shouldn't use it for production).
-
jamesob commented at 3:55 PM on August 22, 2023: member
Fair enough.
- jamesob closed this on Aug 22, 2023
- bitcoin locked this on Aug 21, 2024
