test: default acceptnonstdtxn=0 on all chains #28354

1. 
   ajtowns commented at 5:24 am on August 28, 2023: contributor

   Changes -acceptnonstxtxn to default to 0 on testnet, matching the other chains. Allowing non-standard txs on testnet by default contributed to the difficulties RSK described in #26348: “We see that there are two script paths and, to reduce the script size, a single CHECKMULTISIG is used for the two paths, separating the signer count from the CHECKMULTISIG opcode. This script worked on testnet, because it lacks the standard checks performed in Mainnet.”
2. 
   DrahtBot commented at 5:24 am on August 28, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke, sipa, instagibbs, theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28207 (mempool: Persist with XOR by MarcoFalke)
   • #28132 (policy: Enable full-rbf by default by petertodd)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. in src/init.cpp:588 in 1dcf22188a outdated

   584@@ -585,7 +585,7 @@ void SetupServerArgs(ArgsManager& argsman)
   585 
   586     SetupChainParamsBaseOptions(argsman);
   587 
   588-    argsman.AddArg("-acceptnonstdtxn", strprintf("Relay and mine \"non-standard\" transactions (%sdefault: %u)", "testnet/regtest only; ", !testnetChainParams->RequireStandard()), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::NODE_RELAY);
   589+    argsman.AddArg("-acceptnonstdtxn", strprintf("Relay and mine \"non-standard\" transactions (%sdefault: %u)", "signet/testnet/regtest only; ", DEFAULT_ACCEPT_NON_STD_TXN), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::NODE_RELAY);
   

   ---

   ---

   

   maflcko commented at 5:55 am on August 28, 2023:

   0    argsman.AddArg("-acceptnonstdtxn", strprintf("Relay and mine \"non-standard\" transactions (test networks only; default: %u)", DEFAULT_ACCEPT_NON_STD_TXN), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::NODE_RELAY);
   

   nit: Not sure if every test-only setting must enumerate all test-networks. Should be sufficient if -chain does it, no?

   ---

   

   ajtowns commented at 12:11 pm on August 28, 2023:

   Done
4. 
   maflcko commented at 5:55 am on August 28, 2023: member

   lgtm ACK 1dcf22188a0c81b707c8056b3538c6bd47227a14
5. ajtowns force-pushed on Aug 28, 2023
6. config: default acceptnonstdtxn=0 on all chains

   Previously, the default for acceptnonstdtxn defaulted to 0 on all
   chains except testnet. Change this to be consistent across all
   chains, and remove the parameter from chainparams entirely.

   e1dc15d690
7. doc: Release notes for testnet defaulting to -acceptnonstdtxn=0 13eb8aa572
8. ajtowns force-pushed on Aug 28, 2023
9. 
   maflcko commented at 1:33 pm on August 28, 2023: member

   lgtm ACK 13eb8aa572644a53ae0d631916cb4cbc273a92d1

   I think the pull request title should start with policy: , or test: , no?

10. ajtowns renamed this:
    config: default acceptnonstdtxn=0 on all chains
    test: default acceptnonstdtxn=0 on all chains
    on Aug 28, 2023
11. DrahtBot added the label Tests on Aug 28, 2023
12. 
    sipa commented at 3:00 pm on August 28, 2023: member

    utACK 13eb8aa572644a53ae0d631916cb4cbc273a92d1
13. 
    instagibbs commented at 4:22 pm on August 28, 2023: member

    utACK https://github.com/bitcoin/bitcoin/pull/28354/commits/13eb8aa572644a53ae0d631916cb4cbc273a92d1
14. theStack approved
15. 
    theStack commented at 11:57 pm on August 28, 2023: contributor

    Code-review ACK 13eb8aa572644a53ae0d631916cb4cbc273a92d1
16. fanquake merged this on Aug 29, 2023
17. fanquake closed this on Aug 29, 2023

    ---

18. 
    glozow commented at 8:54 am on August 29, 2023: member

    ACK 13eb8aa572644a53ae0d631916cb4cbc273a92d1
19. 
    jonatack commented at 5:30 pm on August 30, 2023: contributor

    Post-merge ACK.
20. Frank-GER referenced this in commit 81325b7eb9 on Sep 8, 2023

Contributors
ajtowns DrahtBot maflcko sipa instagibbs theStack glozow jonatack

Labels
Tests