update SelectParamsFromCommandLine() handling/order #2837

Diapolo commented at 11:32 AM on July 19, 2013: none

move SelectParamsFromCommandLine() from init.cpp to bitcoin.cpp to allow to use TestNet() for Bitcoin-Qt instead of GetBoolArg("-testnet", false)
change order in bitcoind.cpp to match bitcoin.cpp functionality
hamonize error message strings for missing datadir and failing SelectParamsFromCommandLine() in bitcoin.cpp and bitcoind.cpp
use TestNet() call in splashscreen.cpp

jgarzik commented at 1:29 PM on July 19, 2013: contributor

It is disappointing that this moves away from the init.cpp section used specifically for command line parameters.

BitcoinPullTester commented at 12:15 AM on July 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/205b6c76a131b0690bd9b09af1f25fb486ab0d97 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

gavinandresen commented at 12:30 AM on July 20, 2013: contributor

RE: moving away from init.cpp :

Bitcoin-Qt and bitcoind startup are different, and I think it is cleaner to acknowledge that and have init.cpp be only the shared startup code. I had to make similar changes for the payment protocol work, where Bitcoin-Qt checks command-line arguments and sends a payment request to an already-running instance OR starts itself up in either -testnet or main net mode depending on the contents of the payment request.

But bitcoind doesn't know nuthin about payment requests....

sipa commented at 11:35 AM on July 20, 2013: member

@gavinandresen I would actually like having the payment protocol functionality be available via RPC - like sending a (potentially unsigned) payment request to bitcoind and asking it to give you a payment/signed transaction back. There's no need for having that in a first release though. @Diapolo I haven't tested this yet, but looks good and if pulltester is happy, it's likely to be right. I'll try it soon.

Diapolo commented at 1:45 PM on July 20, 2013: none

Updated to include a proper commit message and harmonize the used error messages.

BitcoinPullTester commented at 11:36 PM on July 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9539c734289fd1f333f70e3c78180d7555c8f2e6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in src/bitcoind.cpp:None in 9539c73428 outdated

  38 | @@ -39,10 +39,15 @@ bool AppInit(int argc, char* argv[])
  39 |          ParseParameters(argc, argv);
  40 |          if (!boost::filesystem::is_directory(GetDataDir(false)))
  41 |          {
  42 | -            fprintf(stderr, "Error: Specified directory does not exist\n");
  43 | +            fprintf(stderr, "Error: Specified data directory \"%s\" does not exist.\n", mapArgs["-datadir"]);

luke-jr commented at 11:36 PM on July 21, 2013:

Isn't this missing a .c_str()?

Diapolo commented at 8:42 AM on July 22, 2013:

Ouch, sure... thanks for catching this.

Diapolo commented at 8:42 AM on July 22, 2013: none

Fixed a missing .c_str(), thanks @luke-jr.

Diapolo referenced this in commit dc55491f97 on Jul 22, 2013

gavinandresen commented at 12:06 AM on July 23, 2013: contributor

I broke pull-tester, I'll fix...

BitcoinPullTester commented at 12:35 AM on July 23, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/3f3353af97948a2634b304455f83a175d0324044 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Diapolo commented at 7:04 AM on July 23, 2013: none

Updated to include - use TestNet() call in splashscreen.cpp.

BitcoinPullTester commented at 8:44 AM on July 23, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/93eb0ca245bdaba8f5f4fde5a835acbc9a97c900 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Diapolo commented at 12:26 PM on July 31, 2013: none

@gavinandresen Can you take a look, perhaps you can then remove the similar commit in your paymentrequest pull. @sipa ping²

BitcoinPullTester commented at 12:10 PM on August 1, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/69267f1947d459bd7e02b573f0b6799424dc5d66 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Diapolo commented at 3:13 PM on August 24, 2013: none

Closing as this was included in the payment request pull.

Diapolo closed this on Aug 24, 2013

IntegralTeam referenced this in commit f8bedba7c4 on Jun 4, 2019

DrahtBot locked this on Sep 8, 2021