Remove needless GetTransactionOutputWeight helper #28431

pull darosior wants to merge 1 commits into bitcoin:master from darosior:2309_remove_unneeded_ser_witness changing 2 files +1 −5
  1. darosior commented at 9:20 am on September 8, 2023: member
    Introduced in #26567. My bad. Thanks AJ for noticing.
  2. consensus/validation.h: remove needless GetTransactionOutputWeight helper
    Introduced in 9b7ec393b82ca9d7ada77d06e0835df0386a8b85. This copied the format of the other Get.*Weight helpers but it's useless for a CTxOut.
    8d6228fc1f
  3. DrahtBot commented at 9:20 am on September 8, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ajtowns

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #28438 (Use serialization parameters for CTransaction by ajtowns)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. darosior commented at 9:20 am on September 8, 2023: member
    cc @ajtowns.
  5. fanquake requested review from achow101 on Sep 8, 2023
  6. ajtowns commented at 4:48 am on September 9, 2023: contributor
    utACK 8d6228fc1fe72db3ac38ab9c853be0256bed5f24
  7. fanquake merged this on Sep 9, 2023
  8. fanquake closed this on Sep 9, 2023

  9. Frank-GER referenced this in commit 673fe98da9 on Sep 19, 2023
  10. bitcoin locked this on Sep 8, 2024


darosior DrahtBot ajtowns


achow101


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me