rpc: Deprecate rpcserialversion=0 #28448

1. 
   ajtowns commented at 7:20 am on September 11, 2023: contributor

   This option was introduced in #9194 to ease the transition to segwit; now that most libraries and apps have been updated it should no longer be necessary.
2. 
   DrahtBot commented at 7:20 am on September 11, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke, Randy808, glozow
   Concept ACK	instagibbs

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28438 (Use serialization parameters for CTransaction by ajtowns)
   • #27433 (getblocktemplate improvements for segwit and sigops by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label RPC/REST/ZMQ on Sep 11, 2023
4. rpc: Deprecate rpcserialversion=0 971bae9174
5. ajtowns force-pushed on Sep 11, 2023
6. 
   ajtowns commented at 7:25 am on September 11, 2023: contributor

   If people do still need this behaviour in the future, a couple of possible solutions:

   • run an old version of bitcoind (ie, anything between 0.13.2 and 26.x) behind a current bitcoind, and use its RPC interface
   • use an intermediate tool to strip the witness data; a patch to bitcoin-util to support stripping witness data from a hex-encoded tx or block is at https://github.com/ajtowns/bitcoin/commits/202309-util-stripwit

   Context for this PR is #28438.

7. ajtowns added this to the milestone 26.0 on Sep 11, 2023
8. 
   maflcko commented at 7:43 am on September 11, 2023: member

   For reference: https://github.com/search?q=rpcserialversion%3D0&type=code

   Also, I am not sure if this is needed in the context of #28438 (comment). It may be better to consider this unrelated from purely internal refactoring going on?

9. 
   ajtowns commented at 11:01 pm on September 11, 2023: contributor

   For reference: https://github.com/search?q=rpcserialversion%3D0&type=code

   This seems to consist of:

   • reference to feature_segwit.py in forks of bitcoin
   • python-bitcoinlib release notes entry from prior to 0.9.0 in Dec 2017
   • opentimestamps-server README prior to April 2018
   • repos scraping github PRs (including this PR itself)
   • blockchain analysis tools that haven’t been updated in years

   Also some altcoin/layered coin things:

   • stacks/stx - https://stacks101.com/stx-mining/setup/bitcoin-node/ (segwit donation address? check! segwit support in the software? uhh…)
   • “lightning cash” altcoin (this seems to be a fork of bitcoin core 0.15 and uses other features that were deprecatedrpc at that time, so code changes here shouldn’t affect it)
   • omnicore (I think this is similar, but has merged up to version 0.20)
10. 
    maflcko commented at 8:33 am on September 12, 2023: member

    review ACK 971bae9174293b79f1f29822d662b31a2ba62234

    Again, I don’t think this is needed or required for #28438, but if there is no use case and user left, it may be best to remove. If there is a major use case or user left, it can be un-deprecated in the future, or an alternative way to achieve the same can be added.

11. 
    Randy808 commented at 11:06 am on September 12, 2023: contributor

    Code Review ACK 971bae9174293b79f1f29822d662b31a2ba62234
12. 
    glozow commented at 11:31 am on September 12, 2023: member

    ACK 971bae9174293b79f1f29822d662b31a2ba62234, seems appropriate to remove. Thanks for looking at usage in #28448 (comment)
13. 
    instagibbs commented at 12:36 pm on September 12, 2023: member

    concept ACK
14. fanquake merged this on Sep 12, 2023
15. fanquake closed this on Sep 12, 2023

    ---

16. Frank-GER referenced this in commit 7971c3b4a8 on Sep 19, 2023
17. bitcoin locked this on Sep 11, 2024

Contributors
ajtowns DrahtBot maflcko Randy808 glozow instagibbs

Labels
RPC/REST/ZMQ

Milestone
26.0