test: Remove unused and confusing call to signrawtransactionwithwallet #28515

1. 
   maflcko commented at 11:20 AM on September 21, 2023: member

   The call is a no-op on this wallet, because it has no relevant keys.

   Fix this by removing the no-op.

   Found in the context of #28437 (comment)

2. test: Remove unused and confusing call to signrawtransactionwithwallet fa88f16c71
3. 
   DrahtBot commented at 11:20 AM on September 21, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Tests on Sep 21, 2023
5. maflcko requested review from achow101 on Sep 21, 2023
6. in test/functional/wallet_fundrawtransaction.py:1067 in fa88f16c71

   1063 | @@ -1064,8 +1064,7 @@ def test_external_inputs(self):
   1064 |  
   1065 |          # Funding should also work if the input weight is provided
   1066 |          funded_tx = wallet.fundrawtransaction(raw_tx, input_weights=[{"txid": ext_utxo["txid"], "vout": ext_utxo["vout"], "weight": input_weight}])
   1067 | -        signed_tx = wallet.signrawtransactionwithwallet(funded_tx["hex"])
   

   ---

   ---

   

   glozow commented at 4:32 PM on September 22, 2023:

   I might be misunderstanding, but should we be keeping the wallet.signrawtransactionwithwallet instead, since ext_utxo is external to node2 and not node0?

7. 
   maflcko commented at 10:41 AM on September 23, 2023: member

   Closing for now, due to controversy. Not worth to spend more than one second on a one-line test patch.

8. maflcko closed this on Sep 23, 2023

   ---

9. maflcko deleted the branch on Sep 23, 2023
10. 
    glozow commented at 10:43 AM on September 23, 2023: member

    Wait sorry :( I meant concept ACK to removing one but wasn't sure which one

11. 
    maflcko commented at 10:47 AM on September 23, 2023: member

    No worries. I think the call doesn't hurt. Fixing the bug in this test section seems more important either way.

    Could cherry-pick this commit into that pull later on :)

12. bitcoin locked this on Sep 22, 2024

Review Requested
achow101