. #28522

pull 0xB10C wants to merge 2 commits into bitcoin:master from 0xB10C:2023-09-verbose-getaddrmaninfo changing 6 files +182 −11
  1. 0xB10C commented at 2:58 PM on September 23, 2023: contributor

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. rpc: getaddrmaninfo verbose for addrman entries
    Exposing address manager table entries in a hidden RPC allows to introspect
    addrman tables in tests and during development.
    d7f483ca30
  3. test: getaddrmaninfo verbose 1d95105ac6
  4. DrahtBot commented at 2:58 PM on September 23, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  5. 0xB10C renamed this:
    2023 09 verbose getaddrmaninfo
    Add getaddrmaninfo verbose
    on Sep 23, 2023
  6. DrahtBot renamed this:
    Add getaddrmaninfo verbose
    Add getaddrmaninfo verbose
    on Sep 23, 2023
  7. 0xB10C marked this as a draft on Sep 23, 2023
  8. 0xB10C renamed this:
    Add getaddrmaninfo verbose
    rpc: add verbose getaddrmaninfo
    on Sep 23, 2023
  9. DrahtBot added the label RPC/REST/ZMQ on Sep 23, 2023
  10. 0xB10C commented at 3:03 PM on September 23, 2023: contributor

    Didn't mean to open this against upstream bitcoin/bitcoin. This isn't ready yet.

  11. 0xB10C closed this on Sep 23, 2023

  12. 0xB10C renamed this:
    rpc: add verbose getaddrmaninfo
    .
    on Sep 23, 2023
  13. bitcoin locked this on Sep 22, 2024
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me