BIP352 tracking issue #28536

This issue will be updated to reflect the current state of BIP352 integration.

PRs ready for review:

• https://github.com/bitcoin-core/secp256k1/pull/1765

Overall plan:

• Pre-work / Refactors

  • #28244
  • #28246
  • #25273
  • #28560
  • #30047
  • #30048
  • #30050
  • #30051

• Send and receive support in the Bitcoin Core wallet:

  • libsecp module (cryptographic portion of the protocol: https://github.com/bitcoin-core/secp256k1/pull/1765
  • Base protocol: #28122
  • Sending: #28201
  • Receiving: #32966

• Light client support:

  • Index for silent payment tweaks (depends on 28122): #28241
  • New BIP157 filter type for tweak data (not started)
  • Serve new filter type (not started)

<details> <summary>Older stuff</summary>

<ul> <li>Closed / Superseded: <ul> <li>Tracking PR (superseded by this issue): [#27827](/bitcoin-bitcoin/27827/)</li> <li>Receiving (superseded by 28453): [#28202](/bitcoin-bitcoin/28202/)</li> <li>Original draft implementation: [#24897](/bitcoin-bitcoin/24897/)</li> <li>Original libsecp256k1 module (superseded by 1519): bitcoin-core/secp256k1/pull/1471</li> <li>https://github.com/bitcoin-core/secp256k1/pull/1519 , (superseded by [#1698](/bitcoin-bitcoin/1698/)) <li> Original receiving PR: [#28453](/bitcoin-bitcoin/28453/)</li> </ul> </li> </ul> </details>

Review comments from #28246 that can be done as follow-ups:

• #28246 (review)
• #28246 (review)
• #28246 (review)

Signet address: tsp1qqwzyz4wvrxnpauh9wj5x0lycvhhf0ff6gv0v0cyc6fcss7knlw3vzquefh7c4j7et3u0f059zw8zzyd97e6j4h4ldfs06t6pen9904w4fvpdukyc

@josibake Sent you some, using a light client so I hope this worked.

Signet: tsp1qqfnlnlnwwrcn7x09u0p0fm6l3698pw9s6mzlg6wv99dempzxmz53sqklscmpcwzkcmuvr4s503w220qgslyhfyxln3tqevfllmu6epvrlu5z457e

@setavenger received, 0.00021000! I tried sending it back but it appears your address is invalid PEBCAK. I'd like to keep this issue focused on the integration for Bitcoin Core, but feel free to join the silent payments IRC channel (#silentpayments) or reach out on twitter (@josibake) so we can keep testing!

• Move base protocol to libsecp as a module (not started)

FWIW, I've started digging a bit deeper into that and started a corresponding discussion in the libsecp256k1 repo: https://github.com/bitcoin-core/secp256k1/issues/1427 (still trying to figure out a sane interface...)

You can point to the actual BIP now in the description 🎉

<details> <summary> Edit: I realized this isn't the right place to discuss this, hiding </summary> I genuinely think silent payments are a good idea and plan on using them myself once they're production ready. However, I wonder if including silent payment support in Bitcoin Core is a good idea, or if instead it would be better to have a separate software on top of Bitcoin Core where the Silent Payments logic is handled - similar to how lightning network nodes or electrum servers are implemented.

From what I can see it will be possible to enable/disable Silent Payments support using the compilation flag, but most users don't compile Bitcoin Core, they download it from the official website, and if the official release binary will have Silent Payments activated, this means that a lot of users will have code they don't need in their nodes. From my point of view, Bitcoin Core should remain as minimal as possible, to decrease the surface of possible attacks, and to make it easier to update and maintain.

I'm interested in exploring the reasons behind this choice. Sorry if this might not be the best place for discussion, in case, let me know where I can ask!

</details>

Hey @Turtlecute33 , this issue is meant to track the status of the PRs and keep track of any follow-ups that might arise. I don't think it's a good place for a general discussion on what should or shouldn't be in Bitcoin Core. I'm not sure of a good place for meta discussions about the project but I'm happy to continue this conversation in the #silentpayments IRC channel

PRs ready for review:

• Add BIP352 module (take 3) bitcoin-core/secp256k1#1698

Add BIP352 module (take 3) bitcoin-core/secp256k1#1698 has been replaced with Add "silentpayments" module implementing BIP352 (take 4, limited to full-node scanning)

Anyone looking to try out silentpayments on bitcoin-core can use #32966, which has sending and receiving support and works on the bitcoin-core gui.

hey guys what is the status of this? If there are blockers can someone describe them?

hey guys what is the status of this? If there are blockers can someone describe them?

Please read the message that is just above yours.

We started trying out/testing silent payments on Bitcoin Core last year.

<img width="939" height="452" alt="Image" src="https://github.com/user-attachments/assets/29353977-570d-41eb-8706-9209f0ae3305" />

<img width="939" height="421" alt="Image" src="https://github.com/user-attachments/assets/695fc161-d8fa-428c-91e9-c6a9b73c6926" />

<img width="940" height="119" alt="Image" src="https://github.com/user-attachments/assets/03d53405-fcf8-4cff-bbc9-f00b954ab714" />

Any assistance, please reach out to us.

Cheers.