Bugfix: configure: Correct check for fuzz binary needing a main function #28564

1. 
   luke-jr commented at 4:09 am on October 3, 2023: member

   Fixes #28563
2. Bugfix: configure: Correct check for fuzz binary needing a main function 8f6ca584cd
3. 
   DrahtBot commented at 4:09 am on October 3, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29208 (build: Bump clang minimum supported version to 14 by maflcko)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   maflcko commented at 7:59 am on October 3, 2023: member

   Can you add steps to reproduce the bug?

   In any case, no objection, but I wonder if this is worth it, given that the cmake transition should be happening soon(TM) after the branch-off. So it may be better to spend effort on checking that cmake does the right thing.

5. maflcko added the label Build system on Oct 3, 2023
6. 
   luke-jr commented at 2:20 pm on October 3, 2023: member

   Can you add steps to reproduce the bug?

   Run ./configure and watch the output

7. hebasto approved
8. 
   hebasto commented at 11:04 am on November 10, 2023: member

   ACK 8f6ca584cd5c0b4882ce6f3c158b6f23aed8f6dc.

   The ./configure script logs are as follow:

   • in the master branch:

   0checking whether main function is needed for fuzz binary... checking whether the linker accepts ... no
   1yes
   

   or

   0checking whether main function is needed for fuzz binary... checking whether the linker accepts ... yes
   1no
   

   • in this PR branch:

   0checking whether main function is needed for fuzz binary... yes
   

   or

   0checking whether main function is needed for fuzz binary... no
   

   I’m using the same approach in the new CMake-based build system (see https://github.com/hebasto/bitcoin/pull/43).

9. 
   maflcko commented at 11:12 am on November 10, 2023: member

   So this is only to fix a test-only debug-only output? Not sure. I guess it can be merged, if cmake does not make it into 27.x. Otherwise it seems odd to change this, when the code will be removed either way before any user will even run or see it.
10. DrahtBot added the label Needs rebase on Jan 12, 2024
11. 
    DrahtBot commented at 10:59 am on January 12, 2024: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

12. achow101 closed this on Apr 9, 2024

    ---

Contributors
luke-jr DrahtBot maflcko hebasto

Labels
Build system Needs rebase