test: BDB wallets #28606

issue maflcko openend this issue on October 6, 2023
  1. maflcko commented at 8:09 am on October 6, 2023: member

    I wonder what the best way is to test BDB wallets, which can still be loaded.

    The current status seems to be that each test is run twice, once with a BDB backend, and once with an sqlite backend. However, this will be harder, once BDB creation is removed. So I wonder what should be done:

    1. Remove coverage for loading and testing with a BDB backend, except for the previous-releases test
    2. Create BDB wallets with a previous release, if available
    3. Everything from 0., but extend the previous-releases test with relevant coverage
    4. Keep -deprecatedrpc=create_bdb in tests and leave everything as-is, remove BDB creation along with BDB loading.
    5. Something else?
  2. maflcko added the label Wallet on Oct 6, 2023
  3. maflcko added the label Tests on Oct 6, 2023
  4. maflcko added the label Brainstorming on Oct 6, 2023
  5. achow101 commented at 3:08 pm on October 6, 2023: member
    The plan is to remove creation and loading at the same time, so this shouldn’t be a problem? Since it is deprecated for now, we can just keep doing 3 until it’s all gone.
  6. maflcko closed this on Oct 6, 2023

  7. bitcoin deleted a comment on Dec 6, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me