test: Fix failing time check in rpc_net.py #28671

1. 
   maflcko commented at 8:36 AM on October 18, 2023: member

   This check fails on slow runners, such as s390x qemu.

   Fix it by using mocktime.

   See #28523 (review)

2. test: Fix failing time check in rpc_net.py fa4c6836c9
3. 
   DrahtBot commented at 8:36 AM on October 18, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	0xB10C, pinheadmz, brunoerg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Oct 18, 2023
5. maflcko requested review from 0xB10C on Oct 18, 2023
6. maflcko added this to the milestone 26.0 on Oct 18, 2023
7. 
   0xB10C commented at 9:11 AM on October 18, 2023: contributor

   ACK fa4c6836c9366c3cc575cb386a397840d5f1aa57

   You could reference your initial report in the OP.

8. DrahtBot removed review request from 0xB10C on Oct 18, 2023
9. pinheadmz approved
10. 
    pinheadmz commented at 6:21 PM on October 18, 2023: member

    ACK fa4c6836c9366c3cc575cb386a397840d5f1aa57

    Nice simple fix. Confirmed locally that setmocktime precisely sets the addr info and otherwise there will always be some discrepancy between when the addr is added and when it is read from the RPC

    <details><summary>Show Signature</summary>

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA256
    
    ACK fa4c6836c9366c3cc575cb386a397840d5f1aa57
    -----BEGIN PGP SIGNATURE-----
    
    iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmUwIacACgkQ5+KYS2KJ
    yTqv8g//SCGTyKRK2ZEiZc6fWnrjDixHTjsl5IIY8Z+TkTkKL0LFiyPhJpQRGS1H
    3NUiju5eVQ4IoCDWwl7ruTv+CTn+wMHU5oxCP8CN/Db8oBavw8iHTKSJ9LVsRrp2
    Nno4pmoG/+Ym24ECC+eJY9Glj5wHgLXYi+TK5vKU7zeMk0L0Zsm5qgR5+apPPGFq
    6CBcPyalesdZRHX7eII81HHh1c4aCNUkEMAO3uCAtUFB12jAuv/3Vb9QrEaeEoZg
    gTDVtc1Na8nX8X5qZ3TKYlgIooYzEl0qAe09waA3kwLJUafODcBwsJQFbZ57ahHc
    jWeLFE5kBQoRa4AKv8/uZpwO60vJgwhE/VyQMkaUIxBdKQj9yjs00pdgneWMSoPi
    Je40migaL2e55rSPRENNCwuwitTxL7a9TLzQdxH0o3xxgaLiCLmhRPQx0aqcwvJv
    4kjJjsGWVluXpto/zd9ffMmUcpcFYTLyrJw7eL57jGBumUmJwMjruEPSn8vAA8a2
    vUley1CXkirQV+tHlf74k1Pr4s3FLJaNh1BZHOg9QPKfRBPmtZ0WLUsK5YV10hsD
    eVSK0lq/+WKAgEaX/lzT/+B7H0dINHEnxU7nYh+vBWT5XuDjfFIO9OyP32u22F1I
    dxm6Vlc0UmP6UmsNq65nUI1uVBvy9Gd3a++POiTAZJV80x0afRQ=
    =aB67
    -----END PGP SIGNATURE-----
    

    pinheadmz's public key is on keybase

    </details>

11. brunoerg approved
12. 
    brunoerg commented at 9:00 PM on October 18, 2023: contributor

    crACK fa4c6836c9366c3cc575cb386a397840d5f1aa57

13. fanquake merged this on Oct 19, 2023
14. fanquake closed this on Oct 19, 2023

    ---

15. maflcko deleted the branch on Oct 19, 2023
16. Frank-GER referenced this in commit 22626bd0cf on Oct 21, 2023
17. bitcoin locked this on Oct 18, 2024

Contributors

maflckoDrahtBot0xB10Cpinheadmzbrunoerg

Milestone
26.0