Added RPC method for dumping wallet addresses without the private keys. #2873

pull CodeShark wants to merge 1 commits into bitcoin:master from CodeShark:dumpaddresses changing 3 files +52 −0

CodeShark commented at 2:52 PM on August 2, 2013: contributor

I figured we needed a convenient address export mechanism that doesn't require decrypting the wallet or knowing any private keys.
Added RPC method for dumping wallet addresses without the private keys. 9bc48eebf8
BitcoinPullTester commented at 3:30 PM on August 2, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9bc48eebf85c1d15f446cad1f92afb22b3a39bea for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 9:57 PM on August 15, 2013: member

This seems like huge code duplication. Perhaps a bool to dumpwallet to hide private keys?
gavinandresen commented at 3:41 AM on August 16, 2013: contributor
NACK.

It is easy to remove the private keys from dumpwallet output, e.g.
```
mkfifo /tmp/foo && (bitcoind dumpwallet /tmp/foo &) && cut -d ' ' -f2- /tmp/foo && rm /tmp/foo
```
Closing.
gavinandresen closed this on Aug 16, 2013
DrahtBot locked this on Sep 8, 2021

Contributors