Wallets should update key/descriptor birthdates when txs older than current birthdates are found #28897

issue achow101 openend this issue on November 16, 2023
  1. achow101 commented at 6:15 pm on November 16, 2023: member

    Please describe the feature you’d like to see added.

    Key/descriptor birthdates should be updated to match the oldest transaction involving the key/descriptor when the timestamp of that transaction is older than the key/descriptor birthdate.

    Users may fail to provide the correct birthdates for things that they imported, which results in the wallet storing incorrect birthdates. Since #27469, birthdates are used to determine whether a block should be scanned. Incorrect birthdates result in the reindex failing to find transactions that already exist in the wallet and subsequently marking them as inactive. While this issue is resolved by reloading the wallet, and rescanning in the worst case, it shouldn’t be necessary to do either of those following a reindex.

    Describe the solution you’d like

    No response

    Describe any alternatives you’ve considered

    No response

    Please leave any additional context

    #19808 (comment)

  2. achow101 added the label Feature on Nov 16, 2023
  3. furszy commented at 1:07 pm on December 4, 2023: member
    #28920 solves it. In case someone else wants to try it.
  4. achow101 referenced this in commit 08e6aaabef on Dec 14, 2023
  5. furszy commented at 5:29 pm on January 4, 2024: member
    Can be closed.
  6. maflcko closed this on Jan 4, 2024


achow101 furszy

Labels
Feature


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me