block.BuildMerkleTree(); is called twice for no reason. Just a few lines above its called the first time. We dont need to check for empty container here before the block.vMerkleTree.back() call, because block.vMerkleTree can not be empty at this point, because block.vtx.empty() has been checked before.
do not call BuildMerkleTree() unnecessarily twice #2890
pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz1 changing 1 files +1 −1-
cozz commented at 1:36 PM on August 10, 2013: contributor
-
do not call BuildMerkleTree() unnecessarily twice c7fa1a3586
- cozz closed this on Aug 10, 2013
- cozz deleted the branch on Aug 10, 2013
- cozz restored the branch on Aug 10, 2013
- cozz reopened this on Aug 10, 2013
-
BitcoinPullTester commented at 2:20 PM on August 10, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c7fa1a358620a785af50c56cc02284990f63c608 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
sipa commented at 8:29 AM on August 11, 2013: member
ACK
- gavinandresen referenced this in commit ac1bd701ba on Aug 12, 2013
- gavinandresen merged this on Aug 12, 2013
- gavinandresen closed this on Aug 12, 2013
- IntegralTeam referenced this in commit 783cb9ca69 on Jun 4, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors