submitpackage: add args “maxfeerate” and “maxburnamount” #28949

issue instagibbs openend this issue on November 27, 2023
  1. instagibbs commented at 4:59 pm on November 27, 2023: member

    Please describe the feature you’d like to see added.

    Currently submitpackage does no sanity checks on submitted transactions.

    These checks have been helpful more than a handful of times in the wild, and these arguments are actively used by downstream wallets. We should figure out how to support them

    No response

    Describe the solution you’d like

    maxfeerate: this one is a bit tricky. I think the easiest way would be have a utility function that pulls in utxos to create the sigops-adjusted vsizes and individual fees? Then the entire package could be rejected if any exceed the set amount.

    maxburnamount: This can be added on without any chain-context by scanning the outputs of each transaction and rejecting the package if any exceed the value.

    Describe any alternatives you’ve considered

    No response

    Please leave any additional context

    No response

  2. instagibbs added the label Feature on Nov 27, 2023
  3. glozow closed this on Mar 18, 2024

  4. glozow referenced this in commit 5d045c31a5 on Mar 18, 2024


instagibbs

Labels
Feature


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me